Review main Merged

18826[BUGFIX] Handle symlink on extension update

Philipp Gampe CR +2 V +2 Normal +56 −2 updated 06/03/13, 20:49

Commit message

If an extension is updated and the extension in the file
system is a symlink to a different directory, all
target directory contents is removed and the update fails.

Introduce a check for symlink and just remove the
symlink in this case.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 2

Review log 9

  1. Christian Kuhn uploaded patch set 2 03/11/13, 19:41

  2. Christian Kuhn commented on patch set 2 03/11/13, 19:41

    Verified; Looks good to me, but someone else must approve @Phillip: I've changed multiple things in patch set 2: * The patch itself was faulty and didn't work (unlink only works properly without trailing slash) * Separated the tests to two different tests, in order to apply to 'one assertion per test only' rule.
  3. Christian Kuhn uploaded patch set 3 03/11/13, 19:41

  4. Philipp Gampe commented on patch set 1 03/11/13, 19:41

    BUG or FEATURE?
  5. Anja Leichsenring commented on patch set 2 03/11/13, 19:41

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 03/11/13, 19:41

  7. Mr. Jenkins commented on patch set 2 03/11/13, 19:41

  8. Christian Kuhn commented on patch set 3 V 0 03/11/13, 19:41

    by team member; Looks good to me, approved Minor test adaption: test files are created in typo3temp, but not in typo3conf/ext anymore. Will merge now.
  9. Christian Kuhn merged patch set 4 03/11/13, 19:41