Review TYPO3_6-0 Merged

18829[BUGFIX] Correct check for extTables script

Francois Suter CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Existence of the script defined in TYPO3_extTableDef_script is
currently achieved by using file_exists(). This is insufficient
if TYPO3_extTableDef_script is defined, but empty, as
file_exists() will match "typo3conf/" and try to include it.

Review

  • Code review CR +2
    • Francois Suter +2
  • Verified V +2
    • Francois Suter +2

Issues 1

Files 1

Review log 3

  1. Francois Suter uploaded patch set 2 03/10/13, 19:54

  2. Francois Suter commented on patch set 2 V 0 03/10/13, 19:54

    by team member; Looks good to me, approved Patch set 2 corrects (= removes) extraneous trailing blank line. No-brainer already merged in master.
  3. Francois Suter merged patch set 3 03/10/13, 19:54