18886[BUGFIX] Make sure XML parser is created everytime when needed
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 5
- typo3/sysext/em/classes/parser/class.tx_em_parser_extensionxmlpullparser.php+16 −3
- typo3/sysext/em/classes/parser/class.tx_em_parser_extensionxmlpushparser.php+17 −5
- typo3/sysext/em/classes/parser/class.tx_em_parser_mirrorxmlpullparser.php+16 −3
- typo3/sysext/em/classes/parser/class.tx_em_parser_mirrorxmlpushparser.php+17 −5
- typo3/sysext/em/classes/parser/class.tx_em_parser_xmlabstractparser.php+8 −0
Review log 6
-
Christian Kuhn commented on patch set 1 03/16/13, 00:09
actually, the parser code is one of the seldom parts in 6.0 / 6.1 extensionmanager that was transferred from old em. so 6.0 and 6.1 are probably affected as well here?! -
Christian Kuhn uploaded patch set 2 03/16/13, 00:09
-
Christian Kuhn commented on patch set 2 03/16/13, 00:09
Verified; Looks good to me, but someone else must approve This issue can be reproduced by commenting the (default) xml pull parser in the factory. I was able to reproduce is 4.5 and 4.7 after that. The bug is confirmed to be fixed by the patch. I was unable to reproduce the issue in 6.1 / 6.0, it seems the new em handles this differently and does not trigger the issue. Still, the code is still similar, so the bugfix should also go to those two versions. -
Marcus Krause commented on patch set 1 03/16/13, 00:09
To reproduce the issue insert public function isAvailable() { return FALSE; } into class tx_em_Parser_MirrorXmlPullParser. The click on retrieve/update button! -
Christian Kuhn commented on patch set 2 V 0 03/16/13, 00:09
by team member; Looks good to me, approved Double checked this is ok. works fine. -
Christian Kuhn merged patch set 3 03/16/13, 00:09