Review TYPO3_4-5 Merged

18886[BUGFIX] Make sure XML parser is created everytime when needed

Marcus Krause CR +2 V +2 Normal +74 −16 updated 06/03/13, 20:49

Commit message

Currently, EM's MirrorXmlPushParser, which is based on ext/xml,
is not properly working. The constructor creates the parser and
within parseXML() method the parser resource is freed.
However, when clicking on retrieve/update button method
parseXML() is invoked multiple times which makes subsequent calls
fail.

Creating the parser is now done within parseXML() method.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 5

Review log 6

  1. Christian Kuhn commented on patch set 1 03/16/13, 00:09

    actually, the parser code is one of the seldom parts in 6.0 / 6.1 extensionmanager that was transferred from old em. so 6.0 and 6.1 are probably affected as well here?!
  2. Christian Kuhn uploaded patch set 2 03/16/13, 00:09

  3. Christian Kuhn commented on patch set 2 03/16/13, 00:09

    Verified; Looks good to me, but someone else must approve This issue can be reproduced by commenting the (default) xml pull parser in the factory. I was able to reproduce is 4.5 and 4.7 after that. The bug is confirmed to be fixed by the patch. I was unable to reproduce the issue in 6.1 / 6.0, it seems the new em handles this differently and does not trigger the issue. Still, the code is still similar, so the bugfix should also go to those two versions.
  4. Marcus Krause commented on patch set 1 03/16/13, 00:09

    To reproduce the issue insert public function isAvailable() { return FALSE; } into class tx_em_Parser_MirrorXmlPullParser. The click on retrieve/update button!
  5. Christian Kuhn commented on patch set 2 V 0 03/16/13, 00:09

    by team member; Looks good to me, approved Double checked this is ok. works fine.
  6. Christian Kuhn merged patch set 3 03/16/13, 00:09