Review main Abandoned

18891[BUGFIX] Importing extensions from repository fails

Christian Futterlieb CR 0 V 0 Easy +1 −0 updated 06/03/13, 20:49

Commit message

The category <=> category_number of an extension is not
resolved correctly in
\TYPO3\CMS\Extensionmanager\Domain\Model\Extension
::getDefaultCategory().

This results in a mysql error, because the category string is not
escaped. It expects it to be an integer.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Mr. Jenkins commented on patch set 1 03/15/13, 00:14

  2. Wouter Wolters commented on patch set 1 03/15/13, 00:14

    Fails; I would prefer that you didn't submit this Thanks for fixing the missing part Christian Futterlieb. But this was not the correct way of pushing another set. When you want to adjust an existing patch you need to commit it with "git commit -a --amend" and not "git commit -a". If you have more questions, jusk ask:-) I have now pushed a 3rd set in the other review. Can you abandon this one?
  3. Christian Kuhn commented on patch set 1 03/15/13, 00:14

    Abandoned