Review TYPO3_6-0 Merged

18892[BUGFIX] Toolbar items with separator: fix white-space

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The toolbar function could output erroneous html is case
additional toolbar items do not bring additionalAttributes.

Additional attributes are defined based on ToolbarItemHookInterface.
But additionalAttributes can be an empty string:

Fix output <liclass="separator"> to <li class="separator">
by adding an extra white-space.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Files 1

Review log 2

  1. Christian Kuhn commented on patch set 1 V 0 03/14/13, 08:59

    by team member; Looks good to me, approved
  2. Christian Kuhn merged patch set 2 03/14/13, 08:59