Review main Merged

18928[TASK] thumbs.php ease require/include path

Felix Kopp CR +2 V +2 Easy +6 −2 updated 06/03/13, 20:49

Commit message

Currently typo3/thumbs.php requires t3lib/thumbs.php and
t3lib/thumbs.php requires EXT:backend/Classes/View/ThumbnailView.php.

Include ThumbnailView directly in typo3/thumbs.php.
But keeps deprecation in place and other files untouched.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2
    • Christian Kuhn +2
    • Benni Mack +1

Files 1

Review log 6

  1. Benni Mack commented on patch set 1 03/22/13, 17:31

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 V 0 03/22/13, 17:31

    by team member; Looks good to me, approved
  3. Felix Kopp commented on patch set 1 03/22/13, 17:31

    Abandoned
  4. Felix Kopp commented on patch set 1 03/22/13, 17:31

    Restored
  5. Mr. Jenkins commented on patch set 1 03/22/13, 17:31

  6. Christian Kuhn merged patch set 2 03/22/13, 17:31