Review TYPO3_6-0 Merged

18967[BUGFIX] Make sure XML parser is created everytime when needed

Christian Kuhn CR +2 V +2 Normal +48 −15 updated 06/03/13, 20:49

Commit message

Currently, EM's MirrorXmlPushParser, which is based on ext/xml,
is not properly working. The constructor creates the parser and
within parseXML() method the parser resource is freed.
However, when clicking on retrieve/update button method
parseXML() is invoked multiple times which makes subsequent calls
fail.

Creating the parser is now done within parseXML() method.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 5

Review log 2

  1. Christian Kuhn commented on patch set 1 V 0 03/16/13, 00:33

    by team member; Looks good to me, approved
  2. Christian Kuhn merged patch set 2 03/16/13, 00:33