Review main Merged

19124[BUGFIX] List module shows thumbs on CEs of type text

Mario Rimann CR +2 V +2 Easy +12 −2 updated 06/03/13, 20:49

Commit message

The list module renders a thumbnail for content elements as soon
as they have an image attached - independent of the current type
of the content element.

This patch changes the behavior, so that the thumbnail for
records in the list view are only shown, if the thumbnail-
column is visible for the current type.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Magdalena Leichsenring +1
    • Anja Leichsenring +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Magdalena Leichsenring +1
    • Anja Leichsenring +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 28

Show 3 earlier messages
  1. Mario Rimann uploaded patch set 2 04/05/13, 13:30

  2. Mario Rimann commented on patch set 3 04/05/13, 13:30

    Fails @Markus Klein: I've had the same thought after some hours of sleep - my patch is broken as it limit's the thumbnail rendering to tt_content-records exclusively. I'll come up with a reworked patch.
  3. Mario Rimann uploaded patch set 4 04/05/13, 13:30

  1. Mario Rimann uploaded patch set 5 04/05/13, 13:30

  2. Mario Rimann uploaded patch set 6 04/05/13, 13:30

  3. Marcus Schwemer commented on patch set 6 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  4. Markus Klein commented on patch set 3 04/05/13, 13:30

    (1 inline comment)

    DatabaseRecordList.php:634

    I'm not entirely sure, if we can/should limit this to tt_content here!?

    DatabaseRecordList.php:637

    !==
  5. Markus Klein uploaded patch set 3 04/05/13, 13:30

  6. Markus Klein commented on patch set 4 2 comments 04/05/13, 13:30

    I would prefer that you didn't submit this CGL and strong comparision
  7. Markus Klein commented on patch set 5 04/05/13, 13:30

    Looks good to me, but someone else must approve
  8. Benni Mack commented on patch set 5 04/05/13, 13:30

    I would prefer that you didn't submit this Shouldn't this be like this? * If we have a thumb col => go one step further * If the field is not empty => go one step further * If the field is visible on the current TCA types, render it This is cleaner instead of the hard-coded workaround
  9. Georg Ringer commented on patch set 6 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  10. Philipp Gampe commented on patch set 6 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  11. Mr. Jenkins commented on patch set 1 04/05/13, 13:30

  12. Mr. Jenkins commented on patch set 2 04/05/13, 13:30

  13. Mr. Jenkins commented on patch set 3 04/05/13, 13:30

  14. Mr. Jenkins commented on patch set 4 04/05/13, 13:30

  15. Mr. Jenkins commented on patch set 5 04/05/13, 13:30

  16. Mr. Jenkins commented on patch set 6 04/05/13, 13:30

  17. Magdalena Leichsenring commented on patch set 6 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  18. Philipp Gampe commented on patch set 7 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  19. Anja Leichsenring commented on patch set 7 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  20. Mr. Jenkins commented on patch set 7 04/05/13, 13:30

  21. Magdalena Leichsenring commented on patch set 7 04/05/13, 13:30

    Verified; Looks good to me, but someone else must approve
  22. Magdalena Leichsenring commented on patch set 7 04/05/13, 13:30

    this is not mission critical, so no backport in 4.x
  23. Magdalena Leichsenring uploaded patch set 7 04/05/13, 13:30

  24. Christian Kuhn commented on patch set 7 V 0 04/05/13, 13:30

    by team member; Looks good to me, approved
  25. Christian Kuhn merged patch set 8 04/05/13, 13:30