19124[BUGFIX] List module shows thumbs on CEs of type text
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Magdalena Leichsenring +1
- Anja Leichsenring +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Magdalena Leichsenring +1
- Anja Leichsenring +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 28
Show 3 earlier messages
-
Mario Rimann uploaded patch set 2 04/05/13, 13:30
-
Mario Rimann commented on patch set 3 04/05/13, 13:30
Fails @Markus Klein: I've had the same thought after some hours of sleep - my patch is broken as it limit's the thumbnail rendering to tt_content-records exclusively. I'll come up with a reworked patch. -
Mario Rimann uploaded patch set 4 04/05/13, 13:30
-
Mario Rimann uploaded patch set 5 04/05/13, 13:30
-
Mario Rimann uploaded patch set 6 04/05/13, 13:30
-
Marcus Schwemer commented on patch set 6 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Markus Klein commented on patch set 3 04/05/13, 13:30
(1 inline comment)DatabaseRecordList.php:634I'm not entirely sure, if we can/should limit this to tt_content here!?DatabaseRecordList.php:635DatabaseRecordList.php:637!== -
Markus Klein uploaded patch set 3 04/05/13, 13:30
-
Markus Klein commented on patch set 4 2 comments 04/05/13, 13:30
I would prefer that you didn't submit this CGL and strong comparision -
Markus Klein commented on patch set 5 04/05/13, 13:30
Looks good to me, but someone else must approve -
Benni Mack commented on patch set 5 04/05/13, 13:30
I would prefer that you didn't submit this Shouldn't this be like this? * If we have a thumb col => go one step further * If the field is not empty => go one step further * If the field is visible on the current TCA types, render it This is cleaner instead of the hard-coded workaround -
Georg Ringer commented on patch set 6 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 6 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7827/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7828/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7830/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7838/ : SUCCESS -
Mr. Jenkins commented on patch set 5 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7854/ : SUCCESS -
Mr. Jenkins commented on patch set 6 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8062/ : SUCCESS -
Magdalena Leichsenring commented on patch set 6 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 7 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 7 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 7 04/05/13, 13:30
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8147/ : SUCCESS -
Magdalena Leichsenring commented on patch set 7 04/05/13, 13:30
Verified; Looks good to me, but someone else must approve -
Magdalena Leichsenring commented on patch set 7 04/05/13, 13:30
this is not mission critical, so no backport in 4.x -
Magdalena Leichsenring uploaded patch set 7 04/05/13, 13:30
-
Christian Kuhn commented on patch set 7 V 0 04/05/13, 13:30
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 8 04/05/13, 13:30