19178[TASK] Improve suhosin checks
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 3
-
Christian Kuhn commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit thisInstaller.php:1360no, please. the return value of the check should consist only of status objects, there should be no empty array entries.Check.php:58please no (public) constants: external api should conist of check method only. switch to a protected property or something, please.Check.php:527Please don't. there should be a status return object in all cases. Same for other checks below. At least please get rid of the empty array entries of the main method return somehow. -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7866/ : SUCCESS -
Wouter Wolters abandoned the change 12/06/14, 18:47
Georg said this can be adadoned.