Review main Abandoned

19178[TASK] Improve suhosin checks

Georg Ringer CR 0 V 0 Normal +25 −37 updated 12/06/14, 18:47

Commit message

If suhosin is not used, it should be mentioned only once

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 3

  1. Christian Kuhn commented on patch set 1 05/27/13, 17:19

    I would prefer that you didn't submit this

    Installer.php:1360

    no, please. the return value of the check should consist only of status objects, there should be no empty array entries.

    Check.php:58

    please no (public) constants: external api should conist of check method only. switch to a protected property or something, please.

    Check.php:527

    Please don't. there should be a status return object in all cases. Same for other checks below. At least please get rid of the empty array entries of the main method return somehow.
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Wouter Wolters abandoned the change 12/06/14, 18:47

    Georg said this can be adadoned.