Review TYPO3_6-0 Merged

19213[BUGFIX] Copy and move folders between storages is broken

Nicole Hummel CR +2 V +2 Normal +77 −19 updated 06/03/13, 20:49

Commit message

If you try to copy a folder from one storage into another one it leads to
a copy in the same (source) storage. This happens because the action is
executed in the source storage and only works with the source folder
object. This is fixed by calling the move method on the target storage
instead.

Besides the copyFolderBetweenStorages function raises an exception which
might be moved into the driver class as the driver should be responsible
for the copy work. Therefore the AbstractDriver should support
(abstract) methods to copy a folder between storages and the local
driver should raises the exception.

Same applies for moving folders between storages.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2

Files 5

Review log 2

  1. Benni Mack commented on patch set 1 V 0 03/23/13, 21:26

    by team member; Looks good to me, approved
  2. Benni Mack merged patch set 2 03/23/13, 21:26