Review main Merged

19218[BUGFIX] Upload in backend does not index file

Steffen Ritter CR +2 V +2 Normal +36 −20 updated 06/03/13, 20:49

Commit message

If a file is uploaded within the backend (f.e. file-module)
the file is not automatically indexed. If done within the
file-module the indexing happens when the folder is shown.
If the file is uploaded somehow else using the
ExtendedFileUtility it's not indexed.

Add the indexing to the upload function.

Review

  • Code review CR +2
    • Benni Mack +2
    • Alexander Opitz +1
    • Anja Leichsenring +1
    • Philipp Gampe +1
  • Verified V +2
    • Benni Mack +2
    • Anja Leichsenring +1
    • Philipp Gampe +1

Files 1

Review log 24

  1. Christian Kuhn uploaded patch set 3 04/06/13, 20:57

  2. Steffen Ritter uploaded patch set 2 04/06/13, 20:57

  3. Alexander Opitz commented on patch set 4 04/06/13, 20:57

    I would prefer that you didn't submit this

    ExtendedFileUtility.php:4

    TYPO3\CMS\Core\Resource\File in your code changes. If you use "use" you also should replace the other usages of TYPO3\CMS\Core\Resource\File and TYPO3\CMS\Core\Utility\GeneralUtility
  4. Steffen Ritter uploaded patch set 4 04/06/13, 20:57

  5. Felix Nagel commented on patch set 3 04/06/13, 20:57

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 04/06/13, 20:57

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7908/ : FAILURE
  7. Mr. Jenkins commented on patch set 2 04/06/13, 20:57

  8. Mr. Jenkins commented on patch set 3 04/06/13, 20:57

  9. Mr. Jenkins commented on patch set 4 04/06/13, 20:57

  10. Wouter Wolters commented on patch set 3 04/06/13, 20:57

    Fails When you upload a file in a folder that is already shown it creates 2 records in sys_file table with different identifiers. Without the patch it creates just one record.
  11. Alexander Opitz commented on patch set 5 04/06/13, 20:57

    Looks good to me, but someone else must approve
  12. Philipp Gampe commented on patch set 5 04/06/13, 20:57

    I would prefer that you didn't submit this will use the fully qualified name in the @return patch is comming
  13. Philipp Gampe commented on patch set 5 04/06/13, 20:57

    in general OK, but I think the @return statements should use the fully qualified class names
  14. Alexander Opitz commented on patch set 6 04/06/13, 20:57

    Looks good to me, but someone else must approve
  15. Philipp Gampe commented on patch set 6 04/06/13, 20:57

    Verified; Looks good to me, but someone else must approve
  16. Philipp Gampe uploaded patch set 6 04/06/13, 20:57

  17. Anja Leichsenring commented on patch set 5 04/06/13, 20:57

    Verified; Looks good to me, but someone else must approve
  18. Anja Leichsenring commented on patch set 6 04/06/13, 20:57

    Verified; Looks good to me, but someone else must approve
  19. Mr. Jenkins commented on patch set 5 04/06/13, 20:57

  20. Mr. Jenkins commented on patch set 6 04/06/13, 20:57

  21. Wouter Wolters commented on patch set 5 04/06/13, 20:57

    Verified; Looks good to me, but someone else must approve
  22. Wouter Wolters uploaded patch set 5 04/06/13, 20:57

  23. Benni Mack commented on patch set 6 V 0 04/06/13, 20:57

    by team member; Looks good to me, approved core review is there.
  24. Benni Mack merged patch set 7 04/06/13, 20:57