19218[BUGFIX] Upload in backend does not index file
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Alexander Opitz +1
- Anja Leichsenring +1
- Philipp Gampe +1
-
Verified V +2
- Benni Mack +2
- Anja Leichsenring +1
- Philipp Gampe +1
Files 1
Review log 24
-
Christian Kuhn uploaded patch set 3 04/06/13, 20:57
-
Steffen Ritter uploaded patch set 2 04/06/13, 20:57
-
Alexander Opitz commented on patch set 4 04/06/13, 20:57
I would prefer that you didn't submit thisExtendedFileUtility.php:4TYPO3\CMS\Core\Resource\File in your code changes. If you use "use" you also should replace the other usages of TYPO3\CMS\Core\Resource\File and TYPO3\CMS\Core\Utility\GeneralUtility -
Steffen Ritter uploaded patch set 4 04/06/13, 20:57
-
Felix Nagel commented on patch set 3 04/06/13, 20:57
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/06/13, 20:57
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/7908/ : FAILURE -
Mr. Jenkins commented on patch set 2 04/06/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7909/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/06/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7912/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/06/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8261/ : SUCCESS -
Wouter Wolters commented on patch set 3 04/06/13, 20:57
Fails When you upload a file in a folder that is already shown it creates 2 records in sys_file table with different identifiers. Without the patch it creates just one record. -
Alexander Opitz commented on patch set 5 04/06/13, 20:57
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 5 04/06/13, 20:57
I would prefer that you didn't submit this will use the fully qualified name in the @return patch is comming -
Philipp Gampe commented on patch set 5 04/06/13, 20:57
in general OK, but I think the @return statements should use the fully qualified class names -
Alexander Opitz commented on patch set 6 04/06/13, 20:57
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 6 04/06/13, 20:57
Verified; Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 6 04/06/13, 20:57
-
Anja Leichsenring commented on patch set 5 04/06/13, 20:57
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 6 04/06/13, 20:57
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 5 04/06/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8265/ : SUCCESS -
Mr. Jenkins commented on patch set 6 04/06/13, 20:57
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8268/ : SUCCESS -
Wouter Wolters commented on patch set 5 04/06/13, 20:57
Verified; Looks good to me, but someone else must approve -
Wouter Wolters uploaded patch set 5 04/06/13, 20:57
-
Benni Mack commented on patch set 6 V 0 04/06/13, 20:57
by team member; Looks good to me, approved core review is there. -
Benni Mack merged patch set 7 04/06/13, 20:57