Review main Merged

19221[BUGFIX] Resource storage does not emit signals

Andreas Wolf CR +2 V +2 Easy +20 −0 updated 06/03/13, 20:49

Commit message

The ResourceStorage class should emit signals before and after most
actions it performs. The emit*() methods are already there, but not
called from the "action" methods. This commit adds the calls where
missing.

Review

  • Code review CR +2
    • Benni Mack +2
    • Alexander Opitz +1
    • Wouter Wolters +1
    • Tom +1
  • Verified V +2
    • Benni Mack +2

Issues 1

Files 1

Review log 6

  1. Tom commented on patch set 1 03/24/13, 09:22

    Looks good to me, but someone else must approve
  2. Alexander Opitz commented on patch set 1 03/24/13, 09:22

    Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 03/24/13, 09:22

  4. Wouter Wolters commented on patch set 1 03/24/13, 09:22

    Looks good to me, but someone else must approve
  5. Benni Mack commented on patch set 1 V 0 03/24/13, 09:22

    by team member; Looks good to me, approved Tested with an example extension.
  6. Benni Mack merged patch set 2 03/24/13, 09:22