Review main Merged

19222[BUGFIX] Folder Tree does not respect _temp_ and _recycler_

Benni Mack CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

The Folder Tree View does not respect temp and
recycler settings, which are identified by the folder
names.

The file list itself does that, because there is a wrong
use of "getIdentifier".

You can see that the foldertree does not show
"Temporary" but "_temp_"  because the comparison
fails every time. The file list works however.

Review

  • Code review CR +2
    • Andreas Wolf +2
    • Wouter Wolters +1
    • Felix Nagel +1
    • Tom +1
  • Verified V +2
    • Andreas Wolf +2
    • Wouter Wolters +1
    • Felix Nagel +1

Issues 1

Files 1

Review log 9

  1. Tom commented on patch set 2 03/24/13, 09:15

    Looks good to me, but someone else must approve
  2. Benni Mack uploaded patch set 2 03/24/13, 09:15

  3. Felix Nagel commented on patch set 2 03/24/13, 09:15

    Verified; Looks good to me, but someone else must approve
  4. Mr. Jenkins commented on patch set 1 03/24/13, 09:15

  5. Mr. Jenkins commented on patch set 2 03/24/13, 09:15

  6. Wouter Wolters commented on patch set 1 03/24/13, 09:15

    Verified; Looks good to me, but someone else must approve
  7. Wouter Wolters commented on patch set 2 03/24/13, 09:15

    Verified; Looks good to me, but someone else must approve
  8. Andreas Wolf commented on patch set 2 V 0 03/24/13, 09:15

    by team member; Looks good to me, approved
  9. Andreas Wolf merged patch set 3 03/24/13, 09:15