Review main Merged

19225[WIP][TASK] Replace static calls to FlashMessageQueue

Wouter Wolters CR +2 V +2 Normal +85 −23 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 2

Files 13

Review log 9

  1. Christian Kuhn commented on patch set 2 V 0 03/29/13, 11:02

    by team member; Looks good to me, approved The two unit tests will be handled with another patch, they need a cleanup anyway.
  2. Christian Kuhn uploaded patch set 3 03/29/13, 11:02

  3. Christian Kuhn uploaded patch set 4 03/29/13, 11:02

  4. Mr. Jenkins commented on patch set 2 03/29/13, 11:02

  5. Mr. Jenkins commented on patch set 4 03/29/13, 11:02

  6. Wouter Wolters commented on patch set 2 03/29/13, 11:02

    Fails 2 unit tests are not ready yet. ./typo3/sysext/core/Tests/Unit/FormProtection/BackendFormProtectionTest.php ./typo3/sysext/core/Tests/Unit/FormProtection/InstallToolFormProtectionTest.php
  7. Wouter Wolters uploaded patch set 2 03/29/13, 11:02

  8. Christian Kuhn commented on patch set 4 V 0 03/29/13, 11:02

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 5 03/29/13, 11:02