Review TYPO3_6-0 Merged

19316[BUGFIX] Segfaults on object comparisons

Christian Kuhn CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

In the ResourceStorage class, the identity of source and target storage
has to be verified for several operations (copy, move). When the
comparison is done with a simple equality operator (==), the properties
of both objects are compared when the objects are not identical. This
comparison led to a segfault in several environments, presumably because
of a meanwhile fixed PHP bug (https://bugs.php.net/bug.php?id=61557).

To prevent these segfaults on affected PHP versions, the comparison is
extended to check for object identity (===). This will not affect the
behaviour of the code, as there should always be only one object per
storage.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 3

  1. Christian Kuhn uploaded patch set 2 03/26/13, 20:17

  2. Christian Kuhn commented on patch set 2 V 0 03/26/13, 20:17

    by team member; Looks good to me, approved
  3. Christian Kuhn merged patch set 3 03/26/13, 20:17