Review main Merged

19336[BUGFIX] Hide foreign_selector if maxitems is reached

Stefan Froemken CR +2 V +2 Easy +5 −1 updated 01/18/15, 20:14

Commit message

If the number of elements is reached (maxitems) then
foreign_selector is still there. If maxitems is reached
it does not make sense keep showing this selector.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Stefan Froemken +1
  • Verified V +2
    • Anja Leichsenring +2
    • Stefan Froemken +1

Issues 1

Files 2

Review log 12

  1. Mattias Nilsson commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Wouter Wolters uploaded patch set 2 05/28/13, 20:11

  4. Mr. Jenkins commented on patch set 2 05/28/13, 20:12

  5. Benni Mack commented on patch set 2 12/11/14, 21:13

    Stefan, care to update this patch? Seems like a great addition!
  6. Mathias Schreiber wrote 12/14/14, 16:14

    Topic changed from 46552 to IRRE
  7. Benni Mack uploaded patch set 3 01/04/15, 09:43

  8. Stefan Froemken commented on patch set 3 V +1 CR +1 01/04/15, 21:05

    Thank you for providing a new patch. Works good. After reloading the page the "New"-Button is there again. I remember that I have problems to get the amount of IRRE-records after reloading the page. Do you see a solution to solve this?
  9. Benni Mack uploaded patch set 4 01/08/15, 19:29

  10. Stefan Froemken voted on patch set 4 CR +1 V +1 01/08/15, 19:40

  11. Anja Leichsenring voted on patch set 4 CR +2 V +2 01/18/15, 20:14

  12. Anja Leichsenring merged patch set 4 01/18/15, 20:14