Review main Merged

19462[TASK] Detect APC and APCu correctly

Stefan Neufeind CR +2 V +2 Easy +5 −3 updated 06/03/13, 20:49

Commit message

APCu is just the user-data part of APC,
providing the same API.

If installed it currently identifies itself
as both "apcu" and "apc" (for compatibility).
Thus if "apcu" shows up, we actually have an APC
without opcache-support.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 3

Review log 9

  1. Stefan Neufeind commented on patch set 1 03/31/13, 16:52

    Tried this with php 5.5.0-beta2 and apcu.
  2. Stefan Neufeind uploaded patch set 2 03/31/13, 16:52

  3. Stefan Neufeind commented on patch set 2 03/31/13, 16:52

    no-brainer
  4. Stefan Neufeind uploaded patch set 3 03/31/13, 16:52

  5. Mr. Jenkins commented on patch set 1 03/31/13, 16:52

  6. Mr. Jenkins commented on patch set 2 03/31/13, 16:52

  7. Mr. Jenkins commented on patch set 3 03/31/13, 16:52

  8. Christian Kuhn commented on patch set 3 V 0 03/31/13, 16:52

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 4 03/31/13, 16:52