Review main Abandoned

19467[FEATURE] Add support for user-data-cache Yac (YacBackend)

Stefan Neufeind CR 0 V 0 Hard +608 −0 updated 01/29/15, 12:29

Commit message

Based on ApcBackend.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 12

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    Imho easy to test. And since it's based on the ApcBackend (and the tests thereof) the cases already cover a good amount.
  2. Philipp Gampe commented on patch set 1 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve

    YacBackend.php:334

    How about yac?
  3. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  4. Stefan Neufeind commented on patch set 1 10/13/13, 10:59

    Could somebody please review? The YAC-API is "small", this patch is based on ApcBackend. Links (as already mentioned on forge): Project: https://github.com/laruence/yac Small collection of some caches available - and Remi also provides RPM-packages for yac for Fedora/RHEL: http://blog.famillecollet.com/post/2013/03/25/PHP-opcode-and-user-data-cache

    YacBackend.php:334 Reply

    The same, as far as I found. There is no functionality to manually trigger GC or the like.
  5. Wouter Wolters wrote 10/16/13, 18:08

    Topic updated from "46822" to "cache".
  6. Stefan Neufeind commented on patch set 1 10/17/13, 09:00

    ping?
  7. Christian Kuhn commented on patch set 1 CR -1 10/17/13, 20:02

    The apc and memcached backends already suffer from the taggability which the backends do not handle very performant. If we still introduce this backend (needs RM ok), then I'd opt to not implement TaggableInterface at all and would call it "SimpleYaCBackend" or something. BTW: This backend then needs documentation in the caching framework section.
  8. Alexander Opitz commented on patch set 1 CR -1 03/03/14, 15:26

    As Yac claims themself "Yac is under developing, please DO NOT use in real productions" I wouldn't add it to core. It should be enough as extension.
  9. Wouter Wolters commented on patch set 1 CR -1 01/03/15, 15:47

    I'm with Alexander here! Stefan can you give a reaction here?
  10. Benni Mack commented on patch set 1 01/29/15, 12:14

    Alex, please recheck the info about YAC. Also, I think the other points should be taken care of. Stefan, could you do that? If somebody is willing to work on this, fine. If nothing happens here, I will abandon this patch in two weeks. If any person would need this in the future he/she can write an extension easily.
  11. Wouter Wolters commented on patch set 1 01/29/15, 12:16

    https://github.com/laruence/yac From the readme: TODO Test in real life applications
  12. Stefan Neufeind abandoned the change 01/29/15, 12:29

    I don't mind anymore. Abandoning by popular demand.