Review main Merged

19482[BUGFIX] Let Upgrade wizard recognize $GLOBALS['TYPO3_CONF_VARS']

Anja Leichsenring CR +2 V +2 Easy +19 −5 updated 06/03/13, 20:49

Commit message

The LocalConfiguration wizard rewrites the existing localconf.php to the
new LocalConfiguration.php. To do so, the lines are read and analyzed to
retrieve the value and translate it to the new structure.

Until now, only lines containing the keyword $TYPO3_CONF_VARS are taken
into account. This patch extends the analysis to the keyword
$GLOBALS['TYPO3_CONF_VARS'].

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Stefan Neufeind +1
    • Markus Klein +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Markus Klein +1
    • Anja Leichsenring +1

Files 1

Review log 9

  1. Stefan Neufeind commented on patch set 2 04/03/13, 15:44

    Looks good to me, but someone else must approve Regex-reading the hard way :-) We might want to add a comment more here or there. But I think I figured it out now.
  2. Markus Klein commented on patch set 2 04/03/13, 15:44

    Verified; Looks good to me, but someone else must approve
  3. Christian Kuhn uploaded patch set 2 04/03/13, 15:44

  4. Christian Kuhn commented on patch set 2 04/03/13, 15:44

    Verified; Looks good to me, but someone else must approve
  5. Anja Leichsenring commented on patch set 2 04/03/13, 15:44

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 04/03/13, 15:44

  7. Mr. Jenkins commented on patch set 2 04/03/13, 15:44

  8. Christian Kuhn commented on patch set 2 V 0 04/03/13, 15:44

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 3 04/03/13, 15:44