Review TYPO3_6-0 Merged

19489[TASK] Adapt ArrayConstraints in IndexerTest

Oliver Hader CR +2 V +2 Easy +8 −4 updated 06/03/13, 20:49

Commit message

The tests for a parameter array check for equality of
the parameter array and the according value.
Instead we only wanna know if two keys are present and
set correctly and we do not care about other array values.

This refactors the Test to be more polite and is a follow-up
for #46596.

Review

  • Code review CR +2
    • Oliver Hader +2
  • Verified V +2
    • Oliver Hader +2

Issues 1

Files 1

Review log 2

  1. Oliver Hader commented on patch set 1 V 0 04/01/13, 13:43

    by team member; Looks good to me, approved Backport from master (even if cruser_id change was not yet affected here, it keeps tests in sync)
  2. Oliver Hader merged patch set 2 04/01/13, 13:43