Review main Merged

19505[TASK] Move code for clearing text fields to jquery plugin

Jost Baron CR +2 V +2 Normal +143 −47 updated 06/03/13, 20:49

Commit message

The code for clearing text fields in the extension manager is now
encapsulated in a jquery plugin, and the form for searching the TER
is automatically submitted if it is cleared and a search result was
shown.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1

Issues 2

Files 7

Review log 12

  1. Mr. Jenkins commented on patch set 1 04/06/13, 17:56

  2. Wouter Wolters commented on patch set 1 04/06/13, 17:56

    Hi Jost, This looks good, one question pops up. Why is jquery.tools changed? Furthermore I think we need to include https://review.typo3.org/#/c/15828/ first. This one will make jquery.tools obsolete. What do you think?
  3. Christian Kuhn commented on patch set 2 04/06/13, 17:56

    @Felix: opinion?
  4. Christian Kuhn commented on patch set 2 04/06/13, 17:56

    Verified; Looks good to me, but someone else must approve
  5. Felix Kopp commented on patch set 2 04/06/13, 17:56

    I would prefere to get a central vierhelper for f:form / input. What about that approach? Anyways looks good

    jquery.clearable.js:54

    does not come from sprite/manager
  6. Felix Kopp commented on patch set 2 04/06/13, 17:56

    (1 inline comment)
  7. Mr. Jenkins commented on patch set 2 04/06/13, 17:56

  8. Wouter Wolters commented on patch set 2 04/06/13, 17:56

    Verified; Looks good to me, but someone else must approve
  9. Wouter Wolters uploaded patch set 2 04/06/13, 17:56

  10. Jost Baron commented on patch set 1 04/06/13, 17:56

    Hi Wouter, https://review.typo3.org/#/c/15828/ should definitely merged first, and this one tested afterwards. Upgrades to jquery 1.9 tend to break stuff. The change in jQuery.tools is only the addition of a missing semicolon at the end of the file, which triggered a syntax error in the merged files.
  11. Christian Kuhn commented on patch set 2 V 0 04/06/13, 17:56

    by team member; Looks good to me, approved
  12. Christian Kuhn merged patch set 3 04/06/13, 17:56