19505[TASK] Move code for clearing text fields to jquery plugin
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
-
Verified V +2
- Christian Kuhn +2
- Wouter Wolters +1
Issues 2
Files 7
- typo3/sysext/extensionmanager/Resources/Private/Layouts/Main.html+3 −1
- typo3/sysext/extensionmanager/Resources/Private/Templates/List/Ter.html+2 −7
- typo3/sysext/extensionmanager/Resources/Public/Css/jquery.clearable.cssnew+19 −0
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/jquery.clearable.js1new+102 −0
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/jquery.tools.min.js+1 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/main.js+5 −21
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/ter.js+11 −17
Review log 12
-
Mr. Jenkins commented on patch set 1 04/06/13, 17:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8093/ : SUCCESS -
Wouter Wolters commented on patch set 1 04/06/13, 17:56
Hi Jost, This looks good, one question pops up. Why is jquery.tools changed? Furthermore I think we need to include https://review.typo3.org/#/c/15828/ first. This one will make jquery.tools obsolete. What do you think? -
Christian Kuhn commented on patch set 2 04/06/13, 17:56
@Felix: opinion? -
Christian Kuhn commented on patch set 2 04/06/13, 17:56
Verified; Looks good to me, but someone else must approve -
Felix Kopp commented on patch set 2 04/06/13, 17:56
I would prefere to get a central vierhelper for f:form / input. What about that approach? Anyways looks goodjquery.clearable.js:54does not come from sprite/manager -
Felix Kopp commented on patch set 2 04/06/13, 17:56
(1 inline comment) -
Mr. Jenkins commented on patch set 2 04/06/13, 17:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8272/ : SUCCESS -
Wouter Wolters commented on patch set 2 04/06/13, 17:56
Verified; Looks good to me, but someone else must approve -
Wouter Wolters uploaded patch set 2 04/06/13, 17:56
-
Jost Baron commented on patch set 1 04/06/13, 17:56
Hi Wouter, https://review.typo3.org/#/c/15828/ should definitely merged first, and this one tested afterwards. Upgrades to jquery 1.9 tend to break stuff. The change in jQuery.tools is only the addition of a missing semicolon at the end of the file, which triggered a syntax error in the merged files. -
Christian Kuhn commented on patch set 2 V 0 04/06/13, 17:56
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 04/06/13, 17:56