Review main Merged

19522[TASK] Clean up DatabaseConnection class

Christian Kuhn CR +2 V +2 Normal +49 −69 updated 10/17/18, 14:33

Commit message

* Reduce number of IDE warnings by fixing method annotations
* Minor nitpicks
* Remove "define visibility" TODOs for API methods

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Files 3

Review log 10

  1. Christian Kuhn uploaded patch set 2 05/27/13, 17:19

  2. Christian Kuhn commented on patch set 2 V 0 05/27/13, 17:19

    by team member; Looks good to me, approved
  3. Markus Klein commented on patch set 3 05/27/13, 17:19

    (1 inline comment)
  4. Christian Kuhn merged patch set 3 05/27/13, 17:19

  5. Anja Leichsenring commented on patch set 2 05/27/13, 17:19

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  7. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  8. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    (1 inline comment)

    DatabaseConnection.php:1081

    boolean
  9. Wouter Wolters commented on patch set 2 05/27/13, 17:19

    Looks good to me, but someone else must approve
  10. Markus Klein commented on patch set 3 10/17/18, 14:33

    DatabaseConnection.php:115

    turns out that replacement went wrong ;-)

    DatabaseConnection.php:731

    Missing datatypes