19522[TASK] Clean up DatabaseConnection class
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Anja Leichsenring +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
Files 3
Review log 10
-
Christian Kuhn uploaded patch set 2 05/27/13, 17:19
-
Christian Kuhn commented on patch set 2 V 0 05/27/13, 17:19
by team member; Looks good to me, approved -
Markus Klein commented on patch set 3 05/27/13, 17:19
(1 inline comment) -
Christian Kuhn merged patch set 3 05/27/13, 17:19
-
Anja Leichsenring commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8102/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8103/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/27/13, 17:19
(1 inline comment)DatabaseConnection.php:1081boolean -
Wouter Wolters commented on patch set 2 05/27/13, 17:19
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 3 10/17/18, 14:33
DatabaseConnection.php:115turns out that replacement went wrong ;-)DatabaseConnection.php:731Missing datatypes