Review main Merged

19524[TASK] Ignore pcntl_* php function in disable_functions check

Wouter Wolters CR +2 V +2 Easy +27 −3 updated 06/03/13, 20:49

Commit message

The check for disable_functions gives a warning on a Ubuntu OS.
To not give a false alarm we set the status to Notice if
only functions are disabled that are currently not used by TYPO3.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Philipp Gampe +1

Issues 1

Files 1

Review log 17

  1. Christian Kuhn commented on patch set 1 04/05/13, 12:54

    I would prefer that you didn't submit this i suggest to not switch to ok if the filter catches something, but to notice. this way ok is given if there is no disabled function, and notice, if there are some that are currently ok to be disabled, else error.
  2. Mr. Jenkins commented on patch set 1 04/05/13, 12:54

  3. Mr. Jenkins commented on patch set 2 04/05/13, 12:54

  4. Wouter Wolters uploaded patch set 2 04/05/13, 12:54

  5. Marcus Schwemer commented on patch set 3 04/05/13, 12:54

    Verified; Looks good to me, but someone else must approve
  6. Mr. Jenkins commented on patch set 3 04/05/13, 12:54

  7. Wouter Wolters uploaded patch set 3 04/05/13, 12:54

  8. Magdalena Leichsenring commented on patch set 3 04/05/13, 12:54

    Verified; Looks good to me, but someone else must approve
  9. Philipp Gampe commented on patch set 4 04/05/13, 12:54

    (1 inline comment)

    Check.php:381

    missing space before are
  10. Mr. Jenkins commented on patch set 4 04/05/13, 12:54

  11. Magdalena Leichsenring uploaded patch set 4 04/05/13, 12:54

  12. Philipp Gampe commented on patch set 5 04/05/13, 12:54

    Verified; Looks good to me, but someone else must approve
  13. Anja Leichsenring commented on patch set 5 04/05/13, 12:54

    Verified; Looks good to me, but someone else must approve
  14. Mr. Jenkins commented on patch set 5 04/05/13, 12:54

  15. Magdalena Leichsenring uploaded patch set 5 04/05/13, 12:54

  16. Christian Kuhn commented on patch set 5 V 0 04/05/13, 12:54

    by team member; Looks good to me, approved
  17. Christian Kuhn merged patch set 6 04/05/13, 12:54