19524[TASK] Ignore pcntl_* php function in disable_functions check
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Philipp Gampe +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 17
-
Christian Kuhn commented on patch set 1 04/05/13, 12:54
I would prefer that you didn't submit this i suggest to not switch to ok if the filter catches something, but to notice. this way ok is given if there is no disabled function, and notice, if there are some that are currently ok to be disabled, else error. -
Mr. Jenkins commented on patch set 1 04/05/13, 12:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8105/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/05/13, 12:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8117/ : SUCCESS -
Wouter Wolters uploaded patch set 2 04/05/13, 12:54
-
Marcus Schwemer commented on patch set 3 04/05/13, 12:54
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 3 04/05/13, 12:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8118/ : SUCCESS -
Wouter Wolters uploaded patch set 3 04/05/13, 12:54
-
Magdalena Leichsenring commented on patch set 3 04/05/13, 12:54
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 4 04/05/13, 12:54
(1 inline comment)Check.php:381missing space before are -
Mr. Jenkins commented on patch set 4 04/05/13, 12:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8144/ : SUCCESS -
Magdalena Leichsenring uploaded patch set 4 04/05/13, 12:54
-
Philipp Gampe commented on patch set 5 04/05/13, 12:54
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 5 04/05/13, 12:54
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 5 04/05/13, 12:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8145/ : SUCCESS -
Magdalena Leichsenring uploaded patch set 5 04/05/13, 12:54
-
Christian Kuhn commented on patch set 5 V 0 04/05/13, 12:54
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 6 04/05/13, 12:54