Review main Merged

19555[BUGFIX] Environment check does not detect Windows OS

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Obvious error. This code is now identical to ext:core
SystemEnvironmentBuilder.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Jigal van Hemert +2
  • Verified V +2
    • Christian Kuhn +2
    • Jigal van Hemert +2

Issues 1

Files 1

Review log 4

  1. Christian Kuhn commented on patch set 1 V 0 04/04/13, 12:48

    by team member; Looks good to me, approved
  2. Jigal van Hemert commented on patch set 1 V 0 04/04/13, 12:48

    by team member; Looks good to me, approved Works with XAMPP for Windows 1.8.1.
  3. Mr. Jenkins commented on patch set 1 04/04/13, 12:48

  4. Christian Kuhn merged patch set 2 04/04/13, 12:48