Review main Merged

19564[BUGFIX] Installer fix crash with faulty DB data

Alexander Opitz CR +2 V +2 Easy +4 −2 updated 06/03/13, 20:49

Commit message

If the database config, given in step 2 of install tool are faulty,
we recognice that for step 3 but try to get all database tables
in that state. Which will crash PHP since MySQLi changes.

You can reproduce this by using faulty DB data on step 2 in the
123-installer.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +1
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 4

  1. Philipp Gampe commented on patch set 1 04/05/13, 11:39

    Verified; Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 1 04/05/13, 11:39

  3. Christian Kuhn commented on patch set 1 V 0 04/05/13, 11:39

    by team member; Looks good to me, approved
  4. Christian Kuhn merged patch set 2 04/05/13, 11:39