Review main Merged

19591[TASK] Extract status identifier to separate property

Nicole Hummel CR +2 V +2 Normal +71 −37 updated 06/03/13, 20:49

Commit message

Instead of parsing the status objects for their classes it is better to
refactor the severity status as own property. So even the CSS class
backparsing can be dropped.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Nicole Hummel +1

Issues 1

Files 9

Review log 23

  1. Mr. Jenkins commented on patch set 1 04/05/13, 17:29

  2. Sascha Egerer uploaded patch set 3 04/05/13, 17:29

    Installer.php:1342

    Can this condition be false? Every serverity has its own class based on an abstract class. So you can't have a serverity "foo" anymore

    Installer.php:1355

    remove the white spaces before closing the tag

    EnvironmentStatusReport.php:51

    Why do we user uppercase here? the only place where we need upperace is in line 72 where the constant is requested.
  3. Sascha Egerer uploaded patch set 4 04/05/13, 17:29

  4. Mr. Jenkins commented on patch set 2 04/05/13, 17:29

  5. Mr. Jenkins commented on patch set 3 04/05/13, 17:29

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8161/ : FAILURE
  6. Mr. Jenkins commented on patch set 4 04/05/13, 17:29

  7. Nicole Hummel uploaded patch set 2 04/05/13, 17:29

  8. Nicole Hummel commented on patch set 2 04/05/13, 17:29

    I would prefer that you didn't submit this Report module has to get some refactor as well
  9. Mr. Jenkins commented on patch set 5 04/05/13, 17:29

  10. Nicole Hummel uploaded patch set 5 04/05/13, 17:29

  11. Sascha Egerer commented on patch set 6 3 comments 04/05/13, 17:29

    I would prefer that you didn't submit this needs some code cleanup
  12. Christian Kuhn uploaded patch set 7 04/05/13, 17:29

  13. Christian Kuhn commented on patch set 7 04/05/13, 17:29

    Verified; Looks good to me, but someone else must approve
  14. Philipp Gampe commented on patch set 6 04/05/13, 17:29

    Verified; Looks good to me, but someone else must approve
  15. Anja Leichsenring commented on patch set 6 04/05/13, 17:29

    Verified; Looks good to me, but someone else must approve
  16. Anja Leichsenring commented on patch set 7 04/05/13, 17:29

    Verified; Looks good to me, but someone else must approve
  17. Mr. Jenkins commented on patch set 6 04/05/13, 17:29

  18. Mr. Jenkins commented on patch set 7 04/05/13, 17:29

  19. Wouter Wolters commented on patch set 7 04/05/13, 17:29

    Looks good to me, but someone else must approve
  20. Nicole Hummel uploaded patch set 6 04/05/13, 17:29

  21. Nicole Hummel commented on patch set 7 04/05/13, 17:29

    Verified; Looks good to me, but someone else must approve
  22. Christian Kuhn commented on patch set 7 V 0 04/05/13, 17:29

    by team member; Looks good to me, approved
  23. Christian Kuhn merged patch set 8 04/05/13, 17:29