19591[TASK] Extract status identifier to separate property
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wouter Wolters +1
- Anja Leichsenring +1
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Nicole Hummel +1
Issues 1
Files 9
- typo3/sysext/install/Classes/Report/EnvironmentStatusReport.php1+14 −12
- typo3/sysext/install/Classes/SystemEnvironment/AbstractStatus.php+15 −3
- typo3/sysext/install/Classes/SystemEnvironment/ErrorStatus.php+5 −0
- typo3/sysext/install/Classes/SystemEnvironment/InfoStatus.php+5 −0
- typo3/sysext/install/Classes/SystemEnvironment/NoticeStatus.php+5 −0
- typo3/sysext/install/Classes/SystemEnvironment/OkStatus.php+5 −0
- typo3/sysext/install/Classes/SystemEnvironment/StatusInterface.php+5 −0
- typo3/sysext/install/Classes/SystemEnvironment/WarningStatus.php+5 −0
- typo3/sysext/install/Classes/Installer.php2+12 −22
Review log 23
-
Mr. Jenkins commented on patch set 1 04/05/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8155/ : SUCCESS -
Sascha Egerer uploaded patch set 3 04/05/13, 17:29
Installer.php:1342Can this condition be false? Every serverity has its own class based on an abstract class. So you can't have a serverity "foo" anymoreInstaller.php:1355remove the white spaces before closing the tagEnvironmentStatusReport.php:51Why do we user uppercase here? the only place where we need upperace is in line 72 where the constant is requested. -
Sascha Egerer uploaded patch set 4 04/05/13, 17:29
-
Mr. Jenkins commented on patch set 2 04/05/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8156/ : SUCCESS -
Mr. Jenkins commented on patch set 3 04/05/13, 17:29
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8161/ : FAILURE -
Mr. Jenkins commented on patch set 4 04/05/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8162/ : SUCCESS -
Nicole Hummel uploaded patch set 2 04/05/13, 17:29
-
Nicole Hummel commented on patch set 2 04/05/13, 17:29
I would prefer that you didn't submit this Report module has to get some refactor as well -
Mr. Jenkins commented on patch set 5 04/05/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8163/ : SUCCESS -
Nicole Hummel uploaded patch set 5 04/05/13, 17:29
-
Sascha Egerer commented on patch set 6 3 comments 04/05/13, 17:29
I would prefer that you didn't submit this needs some code cleanup -
Christian Kuhn uploaded patch set 7 04/05/13, 17:29
-
Christian Kuhn commented on patch set 7 04/05/13, 17:29
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 6 04/05/13, 17:29
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 6 04/05/13, 17:29
Verified; Looks good to me, but someone else must approve -
Anja Leichsenring commented on patch set 7 04/05/13, 17:29
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 6 04/05/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8164/ : SUCCESS -
Mr. Jenkins commented on patch set 7 04/05/13, 17:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8168/ : SUCCESS -
Wouter Wolters commented on patch set 7 04/05/13, 17:29
Looks good to me, but someone else must approve -
Nicole Hummel uploaded patch set 6 04/05/13, 17:29
-
Nicole Hummel commented on patch set 7 04/05/13, 17:29
Verified; Looks good to me, but someone else must approve -
Christian Kuhn commented on patch set 7 V 0 04/05/13, 17:29
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 8 04/05/13, 17:29