Review main Merged

19593[BUGFIX] Move EM extension configuration save button to DocHeader

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

The configuration action brings a Save button.
Save button should be in DocHeader.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • Sascha Egerer +1
    • Jost Baron +1
  • Verified V +2
    • Christian Kuhn +2
    • Alexander Opitz +1
    • Sascha Egerer +1
    • Jost Baron +1

Files 1

Review log 6

  1. Sascha Egerer commented on patch set 1 04/05/13, 16:38

    Verified; Looks good to me, but someone else must approve
  2. Alexander Opitz commented on patch set 1 04/05/13, 16:38

    Verified; Looks good to me, but someone else must approve Wouldn't it be nice to also have the save&close link?
  3. Mr. Jenkins commented on patch set 1 04/05/13, 16:38

  4. Jost Baron commented on patch set 1 04/05/13, 16:38

    Verified; Looks good to me, but someone else must approve +1 for a "save & close" button.
  5. Christian Kuhn commented on patch set 1 V 0 04/05/13, 16:38

    by team member; Looks good to me, approved
  6. Christian Kuhn merged patch set 2 04/05/13, 16:38