Review main Merged

19626[TASK] Add OpenSSL verification to system environment check

Nicole Hummel CR +2 V +2 Easy +31 −0 updated 06/03/13, 20:49

Commit message

Add OpenSSL verification to system environment check to be able to require
rsa and saltedpassword extensions.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Philipp Gampe +1
  • Verified V +2
    • Jigal van Hemert +2
    • Philipp Gampe +1

Issues 1

Files 1

Review log 6

  1. Mr. Jenkins commented on patch set 1 04/06/13, 06:37

  2. Philipp Gampe commented on patch set 2 04/06/13, 06:37

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 2 04/06/13, 06:37

  4. Nicole Hummel uploaded patch set 2 04/06/13, 06:37

  5. Jigal van Hemert commented on patch set 2 V 0 04/06/13, 06:37

    by team member; Looks good to me, approved Tested also with broken OpenSSL and error message is correctly shown.
  6. Jigal van Hemert merged patch set 3 04/06/13, 06:37