Review main Abandoned

19635[BUGFIX] IndexerService updates every indexRecord on every run

Steffen Ritter CR 0 V 0 Easy +21 −4 updated 06/11/14, 11:58

Commit message

If the Indexer is requested to index an file an update sql
query is issued regardless of any change.
Using the FileIndexing Scheduler Task for every file on
every run every record is updated.
Fix the indexer to only issue updates when needed.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 18

  1. Alexander Opitz commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Steffen Ritter updated the commit message in patch set 1 09/01/13, 08:02

  4. Mr. Jenkins commented on patch set 2 09/01/13, 08:04

  5. Stefan Neufeind commented on patch set 2 CR +1 09/01/13, 09:37

    looks quite obvious imho
  6. Andreas Wolf voted on patch set 2 CR +1 09/01/13, 11:07

  7. Alexander Opitz commented on patch set 2 CR +1 09/02/13, 08:56

    @Stefan Can you please rebase the patch?
  8. Alexander Opitz commented on patch set 2 09/02/13, 08:56

    I meant @Steffen ;)
  9. Steffen Ritter uploaded patch set 3 11/10/13, 12:53

  10. Mr. Jenkins commented on patch set 3 11/10/13, 13:09

  11. Kai Ole Hartwig commented on patch set 3 V -1 11/10/13, 13:25

    Fails with: "PHP Warning: array_diff(): Argument #1 is not an array in IndexerService.php line 285" for me.
  12. Stefan Neufeind commented on patch set 3 11/10/13, 13:31

    @Kai: Hmm, that would mean $fileInfo is not an array? Could you please investigate further? At first look it seems like it should at least be the $defaultFileInfo etc. ... no array at all?
  13. Kai Ole Hartwig commented on patch set 3 11/10/13, 14:02

    @Stefan I'll inverstigate this warning. At this point am I not sure why $fileInfo is (maybe?) not an array.
  14. Frans Saris commented on patch set 3 11/10/13, 20:05

    Is this patch still needed for 6.2 as https://review.typo3.org/#/c/24747/ makes it obsolute imo. Or is this only for the older branches?
  15. Kai Ole Hartwig commented on patch set 3 11/10/13, 20:25

    imo it is a 'must have' for 6.2 LTS if this bugfix will merged in 6.0 and 6.1., im o this patch is not obsolete
  16. Steffen Ritter commented on patch set 3 11/16/13, 06:15

    Frans: we should take it to all branches... People might use the old Indexer in 6.2 - older versions definitely will use it
  17. Steffen Ritter commented on patch set 3 12/12/13, 19:30

    Ole: did you investigate it?
  18. Steffen Ritter abandoned the change 06/11/14, 11:58

    This is not relevant for 6.2 anymore and we won't fix it for 6.0 or 6.1 anymore. We highly recommend to upgrade to TYPO3 6.2