19655[WIP][TASK] Set saltedpasswords as required extension
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 20
- typo3/js/loginrefresh.js+3 −35
- typo3/sysext/backend/Classes/Controller/BackendController.php+4 −2
- typo3/sysext/backend/Classes/Controller/LoginController.php+9 −7
- typo3/sysext/backend/Classes/AjaxLoginHandler.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+23 −26
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+3 −10
- typo3/sysext/core/Classes/Core/SystemEnvironmentBuilder.php1+1 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php+23 −4
- typo3/sysext/core/Configuration/FactoryConfiguration.php+3 −1
- typo3/sysext/core/Tests/Unit/Authentication/AbstractUserAuthenticationTest.php+23 −25
- typo3/sysext/install/Classes/Installer.php+0 −5
- typo3/sysext/rsaauth/Classes/Hook/LoginFormHook.php+1 −1
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php+6 −14
- typo3/sysext/saltedpasswords/Classes/Autoloader.phpdeleted+0 −95
- typo3/sysext/saltedpasswords/Classes/class.tx_saltedpasswords_autoloader.phpdeleted+0 −13
- typo3/sysext/sv/Classes/AbstractAuthenticationService.php+2 −8
- typo3/sysext/sv/Classes/AuthenticationService.php+30 −22
- typo3/sysext/sv/Classes/LoginFormHook.phpdeleted+0 −103
- typo3/sysext/sv/class.tx_sv_loginformhook.phpdeleted+0 −8
- typo3/sysext/sv/ext_localconf.php+0 −3
Review log 13
-
Helmut Hummel commented on patch set 1 05/27/13, 17:19
(1 inline comment)SystemEnvironmentBuilder.php:107rsaauth should not be required because it is only needed if no https is available -
Christian Kuhn commented on patch set 1 05/27/13, 17:19
I would prefer that you didn't submit this this still needs work ... was discussed today, nicole will push again. -
Steffen Ritter commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 1 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8230/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Dmitry Dulepov commented on patch set 2 05/27/13, 17:19
Not a -1 but not a good idea in general. If there are other auth methods (such as openid or smsauth), than saltedpasswords may not be needed. Loading every ext takes time and lowers performance. I would make rsaauth required but keep saltedpasswords optional. -
Dmitry Dulepov commented on patch set 2 05/27/13, 17:19
I think that if the password is submitted it MUST be encoded. So we need rsaauth. However the password is not always stored in TYPO3 even if it is submitted (LDAP auth, for example). So we do not always need saltedpasswords. -
Dmitry Dulepov commented on patch set 2 05/27/13, 17:19
Fails For the reasons listed above. I am ready to remove -1 if there are good arguments. -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8306/ : SUCCESS -
Nicole Hummel uploaded patch set 2 05/27/13, 17:19
-
Nicole Hummel commented on patch set 2 05/27/13, 17:19
So this is perfectly the other way around of Helmuts opinion. IMHO there are more systems without an own auth service. So I would suggest to support the majority and make them safe than to optimized for the minority. Hope you get my point. -
Nicole Hummel abandoned the change 08/28/13, 14:29
This patch was splitted into little steps which are currently merged.