Review TYPO3_6-0 Merged

19706[BUGFIX] Warning in getCompressedTCarray due to missing extTables.php

Philipp Gampe CR +2 V +2 Easy +6 −1 updated 06/03/13, 20:49

Commit message

Since 6.0, constant TYPO3_extTableDef_script falls back to string
'extTables.php' if it is not defined otherwise. This might trigger
warnings for unclean code that used this constant before if the file
does not exist.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Christian Kuhn +1

Issues 2

Files 1

Review log 7

  1. Christian Kuhn commented on patch set 1 04/06/13, 20:49

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn uploaded patch set 2 04/06/13, 20:49

  3. Christian Kuhn uploaded patch set 3 04/06/13, 20:49

  4. Christian Kuhn commented on patch set 3 04/06/13, 20:49

    Verified; Looks good to me, but someone else must approve Just change commit message.
  5. Anja Leichsenring commented on patch set 3 04/06/13, 20:49

    Verified; Looks good to me, but someone else must approve
  6. Anja Leichsenring commented on patch set 3 V 0 04/06/13, 20:49

    by team member; Looks good to me, approved
  7. Anja Leichsenring merged patch set 4 04/06/13, 20:49