Review main Merged

19842[TASK] Move two font files from t3lib to ext:core

Christian Kuhn CR +2 V +2 Easy +3 −10 updated 06/03/13, 20:49

Commit message

Some mentions of these files were already adapted, the fonts
are now moved and last occurences fixed.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 6

Review log 8

  1. Christian Kuhn uploaded patch set 2 04/12/13, 19:45

  2. Christian Kuhn commented on patch set 2 V 0 04/12/13, 19:45

    by team member; Looks good to me, approved obvious.
  3. Christian Kuhn commented on patch set 3 04/12/13, 19:45

    (1 inline comment)
  4. Christian Kuhn merged patch set 3 04/12/13, 19:45

  5. Chris topher commented on patch set 3 04/12/13, 19:45

    Hi Christian, I am sure that one of the font files is still used somewhere else. E.g. one of these files is used in typo3\sysext\frontend\Classes\Imaging\GifBuilder.php as fallback for text rendering in GIFBUILDER objects. Search the core for the file names; there maybe are more usages.
  6. Felix Kopp commented on patch set 3 04/12/13, 19:45

    (1 inline comment)

    Installer.php:3073

    that does not look correct.
  7. Mr. Jenkins commented on patch set 2 04/12/13, 19:45

  8. Christian Kuhn commented on patch set 3 04/12/13, 19:45

    gifbuilder was already adapted.