19842[TASK] Move two font files from t3lib to ext:core
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
Issues 1
Files 6
- t3lib/fonts/src/NimbusSansL-Regu.sfd.gzdeletedbinary
- t3lib/fonts/index.htmldeleted+0 −7
- typo3/sysext/core/Resources/Private/Font/nimbus.ttfrenamedbinary
- typo3/sysext/core/Resources/Private/Font/README.txtrenamed+0 −0
- typo3/sysext/core/Resources/Private/Font/vera.ttfrenamedbinary
- typo3/sysext/install/Classes/Installer.php2+3 −3
Review log 8
-
Christian Kuhn uploaded patch set 2 04/12/13, 19:45
-
Christian Kuhn commented on patch set 2 V 0 04/12/13, 19:45
by team member; Looks good to me, approved obvious. -
Christian Kuhn commented on patch set 3 04/12/13, 19:45
(1 inline comment) -
Christian Kuhn merged patch set 3 04/12/13, 19:45
-
Chris topher commented on patch set 3 04/12/13, 19:45
Hi Christian, I am sure that one of the font files is still used somewhere else. E.g. one of these files is used in typo3\sysext\frontend\Classes\Imaging\GifBuilder.php as fallback for text rendering in GIFBUILDER objects. Search the core for the file names; there maybe are more usages. -
Felix Kopp commented on patch set 3 04/12/13, 19:45
(1 inline comment)Installer.php:3073that does not look correct. -
Mr. Jenkins commented on patch set 2 04/12/13, 19:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8360/ : SUCCESS -
Christian Kuhn commented on patch set 3 04/12/13, 19:45
gifbuilder was already adapted.