1987[BUGFIX] Localization of child records fails when using MM type relations
Commit message
Review
-
Code review CR +2
- Susi Moog +2
- Oliver Hader +1
-
Verified V +2
- Susi Moog +2
- Oliver Hader +1
- Philipp Gampe +1
Issues 1
Files 1
Review log 26
Show 1 earlier messages
-
Stefan Neufeind commented on patch set 2 03/11/12, 16:20
Looks good to me, but someone else must approve brief review only, but looks okayneeds to include 4.7 now as well and probably a rebase
-
Stefan Neufeind commented on patch set 3 03/11/12, 16:20
Fetched the changes from https://review.typo3.org/1244 and rebased it (by hand) to 4.5. Haven't yet tested anything though. Somebody please try. -
Stefan Neufeind uploaded patch set 3 03/11/12, 16:20
-
Oliver Hader uploaded patch set 2 03/11/12, 16:20
-
Oliver Hader commented on patch set 3 03/11/12, 16:20
I'm going to do a back port of the version that went into 4.6. -
Andreas Wolf uploaded patch set 5 03/11/12, 16:20
-
Stefan Neufeind commented on patch set 5 03/11/12, 16:20
Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 5 03/11/12, 16:20
easy catch? backport from 4.6 -
Oliver Hader uploaded patch set 4 03/11/12, 16:20
-
Stefan Neufeind commented on patch set 6 03/11/12, 16:20
(1 inline comment) could somebody look into the unittests that Philipp mentioned? -
Oliver Hader uploaded patch set 6 03/11/12, 16:20
-
Oliver Hader commented on patch set 6 03/11/12, 16:20
Verified; Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:1, R:1 as a summary of previous scores (limited to [-1;+1]) V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:1, R:0 from Philipp Gampe <forge.typo3.org@philippgampe.info> -
Jochen Rieger commented on patch set 2 03/11/12, 16:20
No score Philipp, you mean this one? https://review.typo3.org/#change,1244 But that is 4.6 then as a source - ain't it? I'm sorry, I'm not used to the git way of testing and switching yet. -
Jochen Rieger commented on patch set 2 03/11/12, 16:20
Fails I tried it in my local environment. When clicking one of the localization buttons in the inline child record area, nothing happened. Well, the "localize all" button threw the following message in console: "uncaught exception: Element.alignToXY with an element that doesn't exist" In the background however, the child records have been localized ... at least the localization view in the folder containing the child records shows this. I'm using FF5 on OS X. -
Jochen Rieger commented on patch set 3 03/11/12, 16:20
Still no reaction in the form when pressing the localization buttons. Furthermore, the localization button of a non-MM inline element doesn't work either with the patch (at least no visual change in the form). I then checked against 4.5.5-dev without the patch... there the non-MM is working, but of cause the MM-one not. For each test I deleted EVERY cache (typo3conf/temp*, typo3temp/*, Browser Cache, Backend-Db Cache). Seemingly it is a javascript / ExtJS problem... as I found the records localized in their folder most of the time I clicked, but I did not get a reaction in the GUI. -
Philipp Gampe commented on patch set 2 03/11/12, 16:20
could you try the patch from master ... I think it was fixed there, but I am not sure if it applies. Maybe you can find out? -
Philipp Gampe voted on patch set 5 V 0 03/11/12, 16:20
-
Philipp Gampe commented on patch set 6 V 0 03/11/12, 16:20
Works in general, however there is one issue. Sometimes nothing happens if I click localize all. In the background the new record is created, but the interface does not show this. Moreover, if you then click save, it will save the wrong relation (to the untranslated record instead of the translated copy). It works if you open the clink in a new tab (force with browser), the you can save on the new tab and the new tab opens with the correct relation. There is no JavaScript error. -
Philipp Gampe commented on patch set 6 03/11/12, 16:20
Unit tests from irre_tutorial seems to have some trouble with workspaces :( -
Mr. Jenkins commented on patch set 1 03/11/12, 16:20
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/97/ : SUCCESS -
Mr. Jenkins commented on patch set 2 03/11/12, 16:20
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/182/ : SUCCESS -
Mr. Jenkins commented on patch set 3 03/11/12, 16:20
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/267/ : SUCCESS -
Mr. Jenkins commented on patch set 4 03/11/12, 16:20
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/288/ : SUCCESS -
Mr. Jenkins commented on patch set 5 03/11/12, 16:20
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/319/ : SUCCESS -
Susi Moog commented on patch set 6 V 0 03/11/12, 16:20
by team member; Looks good to me, approved Reported my unit test problems at http://forge.typo3.org/issues/34740 Tested and reviewed. Works for me. -
Susi Moog merged patch set 6 03/11/12, 16:20