Review main Merged

19911[BUGFIX] Inefficient cache handling in LocalizationFactory

Christian Kuhn CR +2 V +2 Easy +5 −3 updated 06/03/13, 20:49

Commit message

Calling has() in front of get() is inefficient and can be optimized.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Marc Bastian Heinrichs +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • Marc Bastian Heinrichs +1

Files 1

Review log 5

  1. Marc Bastian Heinrichs commented on patch set 1 04/13/13, 13:35

    Verified; Looks good to me, but someone else must approve
  2. Christian Kuhn commented on patch set 1 V 0 04/13/13, 13:35

    by team member; Looks good to me, approved
  3. Mr. Jenkins commented on patch set 1 04/13/13, 13:35

  4. Wouter Wolters commented on patch set 1 04/13/13, 13:35

    Verified; Looks good to me, but someone else must approve
  5. Christian Kuhn merged patch set 2 04/13/13, 13:35