Review TYPO3_4-7 Abandoned

19912[BUGFIX] _CSS_PAGE_STYLE is added on the page even if config.removeDefaultCss is set

Alina Fleser CR 0 V 0 Easy +2 −2 updated 07/05/13, 12:20

Commit message

Modification of TSpagegen::renderContentWithHeader function to add default CSS(_CSS_DEFAULT_STYLE and _CSS_PAGE_STYLE) only if config.removeDefaultCss is not set.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 3

  1. Chris topher commented on patch set 2 05/27/13, 17:19

    I would prefer that you didn't submit this Hi Alina, thanks for your patch! However, this change does not look right. There are two problems: 1. Before your change only styles, which were added by _CSS_DEFAULT_STYLE were removed. After your change not only styles, which were added by _CSS_DEFAULT_STYLE are removed, but also styles, which are added by _CSS_PAGE_STYLE. That would be a breaking change, which can not be introduced in an already released branch. 2. Note that for TYPO3 6.1 the new property config.removePageCss has been added, which allows to remove both _CSS_DEFAULT_STYLE and _CSS_PAGE_STYLE separately. See #37818. I am currently not completely sure, if that solves the problem, which Julian reported in #39075.
  2. Alina Fleser uploaded patch set 2 05/27/13, 17:19

  3. Steffen Ritter abandoned the change 07/05/13, 12:20

    Only security sixes for TYPO3 4.7 since May 2013