Review TYPO3_4-5 Merged

1999[BUGFIX] Detect Android systems properly

Francois Suter CR +2 V +2 Easy +29 −13 updated 06/03/13, 20:49

Commit message

Android system is not properly detected by
t3lib_utility_Client::getBrowserInfo() because it currently detects
Android devices as variants of a Linux system. However some browsers
don't send "Linux" in the User-Agent, so Android does not get detected
at all. This patch moves Android detection outside of the Linux
detection block. It also comes before Linux detection, so that
Android devices don't get rolled up into Linux computers.

Review

  • Code review CR +2
    • Steffen Gebert +2
  • Verified V +2
    • Steffen Gebert +2

Issues 1

Files 2

Review log 9

  1. Francois Suter commented on patch set 1 06/05/11, 15:16

    Abandoned Sorry, I messed up my "amend" and opened a second review request.
  2. Francois Suter commented on patch set 1 06/05/11, 15:16

    Restored Sorry, I had abandoned the wrong version :-(
  3. Francois Suter commented on patch set 1 06/05/11, 15:16

    This version includes expanded unit tests to cover the problematic user agent string.
  4. Stefan Neufeind commented on patch set 1 06/05/11, 15:16

    Looks good to me, but someone else must approve
  5. Steffen Gebert uploaded patch set 2 06/05/11, 15:16

  6. Steffen Gebert commented on patch set 2 V 0 06/05/11, 15:16

    by team member; Looks good to me, approved Rebased the patch. Review for master branch in I0d870a0b8e7a00bce0dbbf964338f1e83ca821cc
  7. Mr. Jenkins commented on patch set 1 06/05/11, 15:16

  8. Mr. Jenkins commented on patch set 2 06/05/11, 15:16

  9. Steffen Gebert merged patch set 2 06/05/11, 15:16