Review main Merged

2000[BUGFIX] Detect Android systems properly

Francois Suter CR +2 V +2 Easy +29 −13 updated 06/03/13, 20:49

Commit message

Android system is not properly detected by
t3lib_utility_Client::getBrowserInfo() because it currently detects
Android devices as variants of a Linux system. However some browsers
don't send "Linux" in the User-Agent, so Android does not get detected
at all. This patch moves Android detection outside of the Linux
detection block. It also comes before Linux detection, so that
Android devices don't get rolled up into Linux computers.

Review

  • Code review CR +2
    • Steffen Gebert +2
    • Georg Ringer +1
    • Fedir RYKHTIK +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Gebert +2
    • Fedir RYKHTIK +1
    • Philipp Gampe +1

Issues 1

Files 2

Review log 11

  1. Francois Suter uploaded patch set 2 06/05/11, 19:31

  2. Georg Ringer commented on patch set 2 06/05/11, 19:31

    Looks good to me, but someone else must approve
  3. Steffen Gebert commented on patch set 2 V 0 06/05/11, 19:31

    by team member; Looks good to me, approved Really seems to be only Opera Mini. Opera Mobile sends "Linux" in the UA string.
  4. Steffen Gebert merged patch set 2 06/05/11, 19:31

  5. Stefano Kowalke commented on patch set 1 06/05/11, 19:31

    Please update your soures to current master.

    class.t3lib_utility_client.php:150

    Please move the comment in line above the code
  6. Stefano Kowalke commented on patch set 1 06/05/11, 19:31

    (1 inline comment) One inline comment.
  7. Philipp Gampe commented on patch set 2 06/05/11, 19:31

    Verified; Looks good to me, but someone else must approve
  8. Fedir RYKHTIK commented on patch set 2 06/05/11, 19:31

    Verified; Looks good to me, but someone else must approve Looks fine. Minor whitespace issues.
  9. Mr. Jenkins commented on patch set 1 06/05/11, 19:31

    Fails; I would prefer that you didn't submit this Build Failed http://ci.typo3.org/job/typo3-v4-core-gerrit/462/ : FAILURE
  10. Mr. Jenkins commented on patch set 2 06/05/11, 19:31

  11. Francois Suter commented on patch set 2 06/05/11, 19:31

    Thanks for taking care.