Review main Merged

20047[BUGFIX] Resolve asterisk in allowed tables for suggest wizard

Nicole Hummel CR +2 V +2 Easy +16 −1 updated 06/03/13, 20:49

Commit message

In the suggest ajax script the setting of allowed tables is not parsed for
the asterisk (*). If it is set all TCA tables should be parsed and checked
for access and added to queryTables array.

Review

  • Code review CR +2
    • Georg Ringer +2
  • Verified V +2
    • Georg Ringer +2

Files 1

Review log 20

  1. Markus Klein commented on patch set 1 05/04/13, 08:46

    I would prefer that you didn't submit this

    SuggestElement.php:160

    does not make sense! !isset && access to field

    SuggestElement.php:161

    please use () to explicitly specify the precedence of || and &&
  2. Mr. Jenkins commented on patch set 1 05/04/13, 08:46

  3. Markus Klein commented on patch set 2 05/04/13, 08:46

    Nicole, I'm not sure what you mean with your question. Can you please explain a bit more? Thx.
  4. Markus Klein commented on patch set 2 05/04/13, 08:46

    Sure, but did I say anything contrary?
  5. Markus Klein commented on patch set 3 05/04/13, 08:46

    Looks good to me, but someone else must approve Simplified the condition. (Since empty() is used now, the isset() check can be omitted)
  6. Markus Klein uploaded patch set 3 05/04/13, 08:46

  7. Mr. Jenkins commented on patch set 2 05/04/13, 08:46

  8. Mr. Jenkins commented on patch set 3 05/04/13, 08:46

  9. Nicole Hummel commented on patch set 2 05/04/13, 08:46

    Markus, I mean you can't rely that if hideTable is set in the array it is really hidden. So you must check for key existence and proper value as well.
  10. Nicole Hummel commented on patch set 2 05/04/13, 08:46

    @Markus what if hideTable=0 is set (maybe because of laziness of the developer)?
  11. Nicole Hummel uploaded patch set 2 05/04/13, 08:46

  12. Markus Klein commented on patch set 4 05/04/13, 08:46

    I would prefer that you didn't submit this submodules included
  13. Mr. Jenkins commented on patch set 4 05/04/13, 08:46

  14. Nicole Hummel uploaded patch set 4 05/04/13, 08:46

  15. Nicole Hummel commented on patch set 4 05/04/13, 08:46

    I would prefer that you didn't submit this
  16. Mr. Jenkins commented on patch set 5 05/04/13, 08:46

  17. Nicole Hummel uploaded patch set 5 05/04/13, 08:46

  18. Georg Ringer commented on patch set 5 V 0 05/04/13, 08:46

    by team member; Looks good to me, approved
  19. Georg Ringer merged patch set 6 05/04/13, 08:46

  20. Georg Ringer commented on patch set 6 05/04/13, 09:05

    Reverted This patchset was reverted in change: Id5f5b064f9f5bee2431d967646f1729b850ed6a8