20047[BUGFIX] Resolve asterisk in allowed tables for suggest wizard
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
-
Verified V +2
- Georg Ringer +2
Files 1
Review log 20
-
Markus Klein commented on patch set 1 05/04/13, 08:46
I would prefer that you didn't submit thisSuggestElement.php:160does not make sense! !isset && access to fieldSuggestElement.php:161please use () to explicitly specify the precedence of || and && -
Mr. Jenkins commented on patch set 1 05/04/13, 08:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8432/ : SUCCESS -
Markus Klein commented on patch set 2 05/04/13, 08:46
Nicole, I'm not sure what you mean with your question. Can you please explain a bit more? Thx. -
Markus Klein commented on patch set 2 05/04/13, 08:46
Sure, but did I say anything contrary? -
Markus Klein commented on patch set 3 05/04/13, 08:46
Looks good to me, but someone else must approve Simplified the condition. (Since empty() is used now, the isset() check can be omitted) -
Markus Klein uploaded patch set 3 05/04/13, 08:46
-
Mr. Jenkins commented on patch set 2 05/04/13, 08:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8441/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/04/13, 08:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8456/ : SUCCESS -
Nicole Hummel commented on patch set 2 05/04/13, 08:46
Markus, I mean you can't rely that if hideTable is set in the array it is really hidden. So you must check for key existence and proper value as well. -
Nicole Hummel commented on patch set 2 05/04/13, 08:46
@Markus what if hideTable=0 is set (maybe because of laziness of the developer)? -
Nicole Hummel uploaded patch set 2 05/04/13, 08:46
-
Markus Klein commented on patch set 4 05/04/13, 08:46
I would prefer that you didn't submit this submodules included -
Mr. Jenkins commented on patch set 4 05/04/13, 08:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8641/ : SUCCESS -
Nicole Hummel uploaded patch set 4 05/04/13, 08:46
-
Nicole Hummel commented on patch set 4 05/04/13, 08:46
I would prefer that you didn't submit this -
Mr. Jenkins commented on patch set 5 05/04/13, 08:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8642/ : SUCCESS -
Nicole Hummel uploaded patch set 5 05/04/13, 08:46
-
Georg Ringer commented on patch set 5 V 0 05/04/13, 08:46
by team member; Looks good to me, approved -
Georg Ringer merged patch set 6 05/04/13, 08:46
-
Georg Ringer commented on patch set 6 05/04/13, 09:05
Reverted This patchset was reverted in change: Id5f5b064f9f5bee2431d967646f1729b850ed6a8