Review main Merged

20073[TASK] DB-Browser: Pagetree shown even though tables only allow rootLevel

Stefan Neufeind CR +2 V +2 Easy +28 −5 updated 07/02/13, 13:29

Commit message

If only tables with rootLevel=1 in TCA are allowed
to select records from, the pagetree is irritating.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 9

  1. Stefan Neufeind commented on patch set 1 05/27/13, 17:19

    How to test: * Use a field which allows to only select for example be_users and be_groups * Open DB-browser * See pagetree is missing and records from root-level are shown (Also test the opposite still works of course :-)) Candidate for such a field is for example in a workspace-definition the field of be-users and be-groups to notify.
  2. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  3. Wouter Wolters uploaded patch set 2 05/28/13, 20:34

  4. Mr. Jenkins commented on patch set 2 05/28/13, 20:35

  5. Benni Mack voted on patch set 2 V +1 CR +1 07/02/13, 13:16

  6. Wouter Wolters uploaded patch set 3 07/02/13, 13:28

  7. Mr. Jenkins commented on patch set 3 07/02/13, 13:29

  8. Wouter Wolters commented on patch set 3 V +2 CR +2 07/02/13, 13:29

    My change only was 1 => TRUE. 1 is not a real boolean. Benni is next to me and we discussed the change.
  9. Wouter Wolters merged patch set 4 07/02/13, 13:29