Review main Merged

20095[BUGFIX] Fix GeneralUtility::rmdir and usage in tests

Anja Leichsenring CR +2 V +2 Easy +6 −3 updated 06/03/13, 20:49

Commit message

rmdir() has some issues fixed by the patch, especially if
feeded with links:
* If target is a dead link, the link was not removed.
* If target is a link to a directory, only the link should be
  removed, but not the directory the link points to.
* If recursion is disabled, but a directory has sub files or
  directories, a warning might be raised, now suppressed
  with an @.

The method is now fully covered by tests and can handle files,
links and directories. It is now used in GeneralUtilityTest
itself to clean up any created file during tearDown, so a lot
of tests can be streamlined.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Philipp Gampe +2
  • Verified V +2
    • Christian Kuhn +2
    • Philipp Gampe +1

Files 2

Review log 9

  1. Christian Kuhn commented on patch set 1 05/06/13, 18:23

    I would prefer that you didn't submit this working on it.
  2. Christian Kuhn uploaded patch set 2 05/06/13, 18:23

  3. Christian Kuhn commented on patch set 2 05/06/13, 18:23

    Verified; Looks good to me, but someone else must approve
  4. Philipp Gampe commented on patch set 2 05/06/13, 18:23

    Verified; Looks good to me, approved no test is breaking, code looks good However I would prefer an additional test by a windows user.
  5. Anja Leichsenring commented on patch set 1 05/06/13, 18:23

    I would prefer that you didn't submit this This case needs way more unit tests. I will take care asap, but still feel welcome to take over from here. ;)
  6. Mr. Jenkins commented on patch set 1 05/06/13, 18:23

  7. Mr. Jenkins commented on patch set 2 05/06/13, 18:23

  8. Christian Kuhn commented on patch set 2 V 0 05/06/13, 18:23

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 3 05/06/13, 18:23