20095[BUGFIX] Fix GeneralUtility::rmdir and usage in tests
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Philipp Gampe +2
-
Verified V +2
- Christian Kuhn +2
- Philipp Gampe +1
Files 2
Review log 9
-
Christian Kuhn commented on patch set 1 05/06/13, 18:23
I would prefer that you didn't submit this working on it. -
Christian Kuhn uploaded patch set 2 05/06/13, 18:23
-
Christian Kuhn commented on patch set 2 05/06/13, 18:23
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 05/06/13, 18:23
Verified; Looks good to me, approved no test is breaking, code looks good However I would prefer an additional test by a windows user. -
Anja Leichsenring commented on patch set 1 05/06/13, 18:23
I would prefer that you didn't submit this This case needs way more unit tests. I will take care asap, but still feel welcome to take over from here. ;) -
Mr. Jenkins commented on patch set 1 05/06/13, 18:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8451/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/06/13, 18:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8698/ : SUCCESS -
Christian Kuhn commented on patch set 2 V 0 05/06/13, 18:23
by team member; Looks good to me, approved -
Christian Kuhn merged patch set 3 05/06/13, 18:23