20174[CLEANUP] Use proper Clickmenu API
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Stefan Neufeind +1
- Alexander Opitz +1
-
Verified V +2
- Benni Mack +2
- Stefan Neufeind +1
- Alexander Opitz +1
Issues 1
Files 8
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/clickmenu.js+4 −9
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/IndexListRow.html+1 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Compare.html+2 −2
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Index.html+1 −1
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −1
- typo3/sysext/sys_note/Resources/Private/Templates/Note/List.html+1 −1
- typo3/sysext/tstemplate_info/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+3 −3
Review log 16
-
Francois Suter commented on patch set 1 05/27/13, 17:19
Note that this patch also removes the actually deprecated showClickmenu() function. In the source code it is marked as being deprecated since 4.2 and slated for removal in 4.4, so it is ok in theory. In practice, since there's no deprecation log for JS, it might have gone unnoticed and may break existing extensions. I'm fine with leaving it, but when can we clean up JS then? -
Francois Suter commented on patch set 2 05/27/13, 17:19
Same patch, just rebased on current master and changed target version to 6.2. -
Francois Suter uploaded patch set 2 05/27/13, 17:19
-
Oliver Klee commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8488/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8527/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Wouter Wolters uploaded patch set 3 06/29/13, 19:50
-
Mr. Jenkins commented on patch set 3 06/29/13, 19:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9266/ : SUCCESS -
Benni Mack commented on patch set 3 V +1 CR +1 07/01/13, 12:28
yeah, I'm in favor for removing this old method. -
Stefan Neufeind uploaded patch set 4 07/01/13, 18:20
-
Mr. Jenkins commented on patch set 4 07/01/13, 18:21
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9286/ : SUCCESS -
Stefan Neufeind commented on patch set 4 V +1 CR +1 07/01/13, 18:22
Replaced two more occurences. Now core is complete imho. As a separate thing we should look into the showClickmenu_raw()-things and the like (typo3/sysext/backend/Resources/Public/JavaScript/clickmenu.js) -
Alexander Opitz voted on patch set 4 V +1 CR +1 07/01/13, 22:12
-
Benni Mack voted on patch set 4 V +2 CR +2 07/02/13, 12:05
-
Benni Mack merged patch set 5 07/02/13, 12:05