Review main Merged

20174[CLEANUP] Use proper Clickmenu API

Francois Suter CR +2 V +2 Easy +14 −19 updated 07/02/13, 12:05

Commit message

The proper way to call up the CSM is with Clickmenu.show().
Many places in the Core still use the deprecated
showClickmenu() function. This patch replaces them all.

Review

  • Code review CR +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Alexander Opitz +1
  • Verified V +2
    • Benni Mack +2
    • Stefan Neufeind +1
    • Alexander Opitz +1

Issues 1

Files 8

Review log 16

  1. Francois Suter commented on patch set 1 05/27/13, 17:19

    Note that this patch also removes the actually deprecated showClickmenu() function. In the source code it is marked as being deprecated since 4.2 and slated for removal in 4.4, so it is ok in theory. In practice, since there's no deprecation log for JS, it might have gone unnoticed and may break existing extensions. I'm fine with leaving it, but when can we clean up JS then?
  2. Francois Suter commented on patch set 2 05/27/13, 17:19

    Same patch, just rebased on current master and changed target version to 6.2.
  3. Francois Suter uploaded patch set 2 05/27/13, 17:19

  4. Oliver Klee commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 05/27/13, 17:19

  6. Mr. Jenkins commented on patch set 2 05/27/13, 17:19

  7. Wouter Wolters commented on patch set 1 05/27/13, 17:19

    Looks good to me, but someone else must approve
  8. Wouter Wolters uploaded patch set 3 06/29/13, 19:50

  9. Mr. Jenkins commented on patch set 3 06/29/13, 19:50

  10. Benni Mack commented on patch set 3 V +1 CR +1 07/01/13, 12:28

    yeah, I'm in favor for removing this old method.
  11. Stefan Neufeind uploaded patch set 4 07/01/13, 18:20

  12. Mr. Jenkins commented on patch set 4 07/01/13, 18:21

  13. Stefan Neufeind commented on patch set 4 V +1 CR +1 07/01/13, 18:22

    Replaced two more occurences. Now core is complete imho. As a separate thing we should look into the showClickmenu_raw()-things and the like (typo3/sysext/backend/Resources/Public/JavaScript/clickmenu.js)
  14. Alexander Opitz voted on patch set 4 V +1 CR +1 07/01/13, 22:12

  15. Benni Mack voted on patch set 4 V +2 CR +2 07/02/13, 12:05

  16. Benni Mack merged patch set 5 07/02/13, 12:05