20272[FEATURE] New TCA displayCond options BIT and !BIT
Commit message
Review
-
Code review CR +2
- Stefan Neufeind +2
- Philipp Gampe +1
-
Verified V +2
- Stefan Neufeind +2
- Philipp Gampe +1
Issues 1
Files 2
Review log 8
-
Stefan Neufeind commented on patch set 1 05/05/13, 11:54
Looks good to me, but someone else must approve I've thought about other names. Maybe MASK (as "BITMASK" is too long)? This would make it more clear that not just one bit is checked (like giving numbers 1 to 8 for each bit of a byte) but that this function actually uses a bitmask and values have to be given accordingly. -
Stefan Neufeind commented on patch set 2 05/05/13, 11:54
Verified; Looks good to me, but someone else must approve -
Stefan Neufeind commented on patch set 2 V 0 05/05/13, 11:54
by team member; Looks good to me, approved Documentation-issue added on forge -
Philipp Gampe commented on patch set 2 05/05/13, 11:54
Verified; Looks good to me, but someone else must approve I fixed the unit test to actually test real bitmasks. -
Philipp Gampe uploaded patch set 2 05/05/13, 11:54
-
Mr. Jenkins commented on patch set 1 05/05/13, 11:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8515/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/05/13, 11:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8681/ : SUCCESS -
Stefan Neufeind merged patch set 3 05/05/13, 11:54