20277[FEATURE] Add task to auto update languages
Commit message
Review
-
Code review CR +2
- Anja Leichsenring +2
- Stefan Neufeind +1
- Eric Chavaillaz +1
- Xavier Perseguers +1
- Philipp Gampe +1
-
Verified V +2
- Anja Leichsenring +2
- Eric Chavaillaz +1
- Xavier Perseguers +1
- Philipp Gampe +1
Issues 1
Files 5
- typo3/sysext/lang/Classes/Command/UpdateCommandController.phpnew+65 −0
- typo3/sysext/lang/Classes/Controller/LanguageController.php+3 −131
- typo3/sysext/lang/Classes/Service/UpdateTranslationService.php3new+184 −0
- typo3/sysext/lang/Resources/Private/Language/locallang.xlf+0 −1
- typo3/sysext/lang/ext_localconf.php+3 −0
Review log 19
-
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8519/ : FAILURE -
Stefan Neufeind commented on patch set 2 05/27/13, 17:19
(2 inline comments)commit-msg should imho also mention creation of the languages-service.UpdateTranslationService.php:34Should we maybe leave out the "update"-part in the name since it does more than just updating? And since "translationService" would be quite generic, maybe something like "moduleTranslationService"? Called "Translation" here, called "languages" in the next file ... hmm. -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve works for me A nice extension: Add a selector for the languages such that you can select the languages to update. This would reduce the execution time which might be limited on certain systems. E.g. my hoster has a much runtime of 30 CPU seconds (90s total) - if you update many languages, this might not be enough. -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8521/ : SUCCESS -
Wouter Wolters uploaded patch set 2 05/27/13, 17:19
-
Wouter Wolters uploaded patch set 3 06/11/13, 19:47
-
Mr. Jenkins commented on patch set 3 06/11/13, 19:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9038/ : SUCCESS -
Eric Chavaillaz commented on patch set 3 V +1 CR +1 06/23/13, 14:34
Great! But I purpose to change the comment in the file ext_localconf.php. Now it is "// Register extension list update task", I purpose "// Register languages update task" -
Chris topher commented on patch set 3 06/23/13, 15:17
Sitenote: It is possible that currently you do not get the newest translations when you update from Translation Server. This is a problem on the Translation Server; it does not mean that the patch would be broken. -
Christian Kuhn commented on patch set 3 06/23/13, 20:54
No real vote yet, but some comments ... could we use the commandcontroller of extbase for this task? would be a great showcase ...UpdateTranslationService.php:9@Wouter: Its "your" file, your copyright, remove the others.UpdateTranslationService.php:32I tend to omit this line in my files.UpdateLanguagesTask.php:32btw: it might be easier to use the CommandController of extbase for this. This could be a cool showcase in the core how the command controller works. -
Wouter Wolters uploaded patch set 4 06/23/13, 21:38
-
Mr. Jenkins commented on patch set 4 06/23/13, 21:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9203/ : SUCCESS -
Philipp Gampe voted on patch set 4 V +1 CR +1 06/23/13, 22:44
-
Philipp Gampe commented on patch set 4 06/23/13, 22:45
It is a pity that the new task does not show up the in tasks list, but hides inside the extbase command controller task. But this has to be solved inside scheduler. -
Eric Chavaillaz commented on patch set 4 V +1 CR +1 06/24/13, 06:02
I agree with Philipp for the visibility of the task. But it seems to be ok. -
Xavier Perseguers commented on patch set 4 V +1 CR +1 06/24/13, 09:54
Yes, scheduler tasks with Extbase need some additional love :) -
Stefan Neufeind commented on patch set 4 CR +1 06/24/13, 10:03
About the extbase-scheduler-tasks: separate issue filed for that. http://forge.typo3.org/issues/49375 -
Anja Leichsenring commented on patch set 4 V +2 CR +2 06/24/13, 19:26
thank you vory much Wouter for this great improvement. -
Anja Leichsenring merged patch set 5 06/24/13, 19:26