Review main Merged

20278[FEATURE] Add missing stdWrap to the new "strPad" properties

Wouter Wolters CR +2 V +2 Normal +46 −6 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Stefan Neufeind +1
  • Verified V +2
    • Philipp Gampe +2
    • Stefan Neufeind +1

Issues 1

Files 2

Review log 10

  1. Stefan Neufeind commented on patch set 1 05/05/13, 12:24

    Looks good to me, but someone else must approve
  2. Stefan Neufeind uploaded patch set 2 05/05/13, 12:24

  3. Stefan Neufeind commented on patch set 2 05/05/13, 12:24

    Verified; Looks good to me, but someone else must approve
  4. Stefan Neufeind commented on patch set 2 05/05/13, 12:24

    added doc-issue on forge. imho this is done.
  5. Chris topher commented on patch set 1 05/05/13, 12:24

    Verified; Looks good to me, but someone else must approve
  6. Philipp Gampe commented on patch set 1 05/05/13, 12:24

    I would prefer that you didn't submit this Misses unit test ... this should be really easy to test. Have a look at the other tests and test for something like .wrap. Report back if you need help with the tests.
  7. Mr. Jenkins commented on patch set 1 05/05/13, 12:24

  8. Mr. Jenkins commented on patch set 2 05/05/13, 12:24

  9. Philipp Gampe commented on patch set 2 V 0 05/05/13, 12:24

    by team member; Looks good to me, approved Tested with unit tests.
  10. Philipp Gampe merged patch set 3 05/05/13, 12:24