20437[BUGFIX] ProcessedFile is persisted in sys_file as well
Commit message
Review
-
Code review CR +2
- Philipp Gampe +2
- Stefan Neufeind +1
- Alexander Opitz +1
- Wouter Wolters +1
- Frans Saris +1
-
Verified V +2
- Philipp Gampe +2
- Alexander Opitz +1
- Wouter Wolters +1
Files 3
Review log 36
Show 11 earlier messages
-
Alexander Opitz commented on patch set 2 05/17/13, 14:55
I would prefer that you didn't submit this3 lines? Why not "Releases: 6.2, 6.1, 6.0"?AbstractFile.php:43@var boolean|NULL ?AbstractFile.php:577From description: The var $this->indexed means if a file _is_ indexed or not The function index means if a file _should be_ indexed or not So maybe the description do not match. -
Alexander Opitz commented on patch set 2 05/17/13, 14:55
(1 inline comment) -
Fabien Udriot uploaded patch set 2 05/17/13, 14:55
Reply
What is the habit here?AbstractFile.php:577ReplyI agree this is a bit clumsy. Furthermore it should not be possible to set this property like that. Will issue another patch. -
Fabien Udriot commented on patch set 2 05/17/13, 14:55
(1 inline comment) -
Fabien Udriot commented on patch set 2 05/17/13, 14:55
(1 inline comment) -
Alexander Opitz commented on patch set 3 05/17/13, 14:55
(1 inline comment) -
Alexander Opitz commented on patch set 3 05/17/13, 14:55
(1 inline comment) -
Philipp Gampe commented on patch set 3 05/17/13, 14:55
(1 inline comment) -
Philipp Gampe commented on patch set 3 05/17/13, 14:55
a unit test is missing here -
Mattias Nilsson commented on patch set 3 05/17/13, 14:55
Looks good to me, but someone else must approve -
Fabien Udriot commented on patch set 3 05/17/13, 14:55
Latest patch fixes the comments of patch set version 1
-
Fabien Udriot commented on patch set 3 05/17/13, 14:55
(1 inline comment) -
Fabien Udriot uploaded patch set 3 05/17/13, 14:55
-
Alexander Opitz commented on patch set 4 05/17/13, 14:55
(3 inline comments) -
Fabien Udriot commented on patch set 4 05/17/13, 14:55
(3 inline comments) -
Fabien Udriot uploaded patch set 4 05/17/13, 14:55
-
Fabien Udriot commented on patch set 4 05/17/13, 14:55
Added unit test + updated method name according comments in patch 4 -
Fabien Udriot uploaded patch set 5 05/17/13, 14:55
-
Stefan Neufeind commented on patch set 6 05/17/13, 14:55
Looks good to me, but someone else must approve -
Alexander Opitz commented on patch set 6 V 0 05/17/13, 14:55
Tested clean install with introduction package. Now only the icons in "/typo3/sysext/..." are left. -
Alexander Opitz commented on patch set 6 05/17/13, 14:55
Looks good to me, but someone else must approve Fine :-D -
Philipp Gampe commented on patch set 6 05/17/13, 14:55
(1 inline comment) -
Fabien Udriot commented on patch set 6 05/17/13, 14:55
Alright, ready for comment. Have addressed Alexander comments -
Fabien Udriot uploaded patch set 6 05/17/13, 14:55
-
Frans Saris commented on patch set 2 05/17/13, 14:55
Verified; Looks good to me, but someone else must approve -
Frans Saris commented on patch set 6 1 comment 05/17/13, 14:55
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 05/17/13, 14:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8602/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/17/13, 14:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8605/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/17/13, 14:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8786/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/17/13, 14:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8787/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/17/13, 14:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8788/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/17/13, 14:55
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/8789/ : SUCCESS -
Wouter Wolters commented on patch set 2 05/17/13, 14:55
(1 inline comment)Reply
AFAIK it is one line. In the wiki it is also given as one line: http://wiki.typo3.org/CommitMessage_Format_%28Git%29 -
Wouter Wolters commented on patch set 6 05/17/13, 14:55
Verified; Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 6 V 0 05/17/13, 14:55
by team member; Looks good to me, approved Merging this now, but the API needs more cleanup for indexing: http://forge.typo3.org/issues/48349 -
Philipp Gampe merged patch set 7 05/17/13, 14:55