Review main Merged

20437[BUGFIX] ProcessedFile is persisted in sys_file as well

Fabien Udriot CR +2 V +2 Normal +60 −10 updated 06/03/13, 20:49

Commit message

The problem appears more generally as soon as @getProperties@ is
called from a file object. FAL will try, by all means, indexing the file
(storing the file into sys_file, in other word)

The change set adds a method telling a File not be indexed by the API.
This is particularly useful if you want to create objects but don't want
them to be persisted.

Review

  • Code review CR +2
    • Philipp Gampe +2
    • Stefan Neufeind +1
    • Alexander Opitz +1
    • Wouter Wolters +1
    • Frans Saris +1
  • Verified V +2
    • Philipp Gampe +2
    • Alexander Opitz +1
    • Wouter Wolters +1

Files 3

Review log 36

Show 11 earlier messages
  1. Alexander Opitz commented on patch set 2 05/17/13, 14:55

    I would prefer that you didn't submit this
    3 lines? Why not "Releases: 6.2, 6.1, 6.0"?

    AbstractFile.php:43

    @var boolean|NULL ?

    AbstractFile.php:577

    From description: The var $this->indexed means if a file _is_ indexed or not The function index means if a file _should be_ indexed or not So maybe the description do not match.
  2. Alexander Opitz commented on patch set 2 05/17/13, 14:55

    (1 inline comment)
  3. Fabien Udriot uploaded patch set 2 05/17/13, 14:55

    Reply

    What is the habit here?

    AbstractFile.php:577 Reply

    I agree this is a bit clumsy. Furthermore it should not be possible to set this property like that. Will issue another patch.
  4. Fabien Udriot commented on patch set 2 05/17/13, 14:55

    (1 inline comment)
  5. Fabien Udriot commented on patch set 2 05/17/13, 14:55

    (1 inline comment)
  6. Alexander Opitz commented on patch set 3 05/17/13, 14:55

    (1 inline comment)
  7. Alexander Opitz commented on patch set 3 05/17/13, 14:55

    (1 inline comment)
  8. Philipp Gampe commented on patch set 3 05/17/13, 14:55

    (1 inline comment)
  9. Philipp Gampe commented on patch set 3 05/17/13, 14:55

    a unit test is missing here
  10. Mattias Nilsson commented on patch set 3 05/17/13, 14:55

    Looks good to me, but someone else must approve
  11. Fabien Udriot commented on patch set 3 05/17/13, 14:55

    Latest patch fixes the comments of patch set version 1
  1. Fabien Udriot commented on patch set 3 05/17/13, 14:55

    (1 inline comment)
  2. Fabien Udriot uploaded patch set 3 05/17/13, 14:55

  3. Alexander Opitz commented on patch set 4 05/17/13, 14:55

    (3 inline comments)
  4. Fabien Udriot commented on patch set 4 05/17/13, 14:55

    (3 inline comments)
  5. Fabien Udriot uploaded patch set 4 05/17/13, 14:55

  6. Fabien Udriot commented on patch set 4 05/17/13, 14:55

    Added unit test + updated method name according comments in patch 4
  7. Fabien Udriot uploaded patch set 5 05/17/13, 14:55

  8. Stefan Neufeind commented on patch set 6 05/17/13, 14:55

    Looks good to me, but someone else must approve
  9. Alexander Opitz commented on patch set 6 V 0 05/17/13, 14:55

    Tested clean install with introduction package. Now only the icons in "/typo3/sysext/..." are left.
  10. Alexander Opitz commented on patch set 6 05/17/13, 14:55

    Looks good to me, but someone else must approve Fine :-D
  11. Philipp Gampe commented on patch set 6 05/17/13, 14:55

    (1 inline comment)
  12. Fabien Udriot commented on patch set 6 05/17/13, 14:55

    Alright, ready for comment. Have addressed Alexander comments
  13. Fabien Udriot uploaded patch set 6 05/17/13, 14:55

  14. Frans Saris commented on patch set 2 05/17/13, 14:55

    Verified; Looks good to me, but someone else must approve
  15. Frans Saris commented on patch set 6 1 comment 05/17/13, 14:55

    Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 1 05/17/13, 14:55

  17. Mr. Jenkins commented on patch set 2 05/17/13, 14:55

  18. Mr. Jenkins commented on patch set 3 05/17/13, 14:55

  19. Mr. Jenkins commented on patch set 4 05/17/13, 14:55

  20. Mr. Jenkins commented on patch set 5 05/17/13, 14:55

  21. Mr. Jenkins commented on patch set 6 05/17/13, 14:55

  22. Wouter Wolters commented on patch set 2 05/17/13, 14:55

    (1 inline comment)

    Reply

    AFAIK it is one line. In the wiki it is also given as one line: http://wiki.typo3.org/CommitMessage_Format_%28Git%29
  23. Wouter Wolters commented on patch set 6 05/17/13, 14:55

    Verified; Looks good to me, but someone else must approve
  24. Philipp Gampe commented on patch set 6 V 0 05/17/13, 14:55

    by team member; Looks good to me, approved Merging this now, but the API needs more cleanup for indexing: http://forge.typo3.org/issues/48349
  25. Philipp Gampe merged patch set 7 05/17/13, 14:55