Review main Merged

20438[TASK] Use GeneralUtility namespace in Installer.php

Christian Kuhn CR +2 V +2 Normal +103 −101 updated 06/03/13, 20:49

Commit message

This makes Installer.php better readable due to shorter lines.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 1

Files 1

Review log 9

  1. Christian Kuhn commented on patch set 1 05/02/13, 18:18

    I would prefer that you didn't submit this
  2. Christian Kuhn uploaded patch set 2 05/02/13, 18:18

  3. Christian Kuhn commented on patch set 2 05/02/13, 18:18

    I would prefer that you didn't submit this
  4. Christian Kuhn uploaded patch set 3 05/02/13, 18:18

  5. Mr. Jenkins commented on patch set 1 05/02/13, 18:18

    Fails; I would prefer that you didn't submit this Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/8603/ : FAILURE
  6. Mr. Jenkins commented on patch set 2 05/02/13, 18:18

  7. Mr. Jenkins commented on patch set 3 05/02/13, 18:18

  8. Christian Kuhn commented on patch set 3 V 0 05/02/13, 18:18

    by team member; Looks good to me, approved Very simple replace ...
  9. Christian Kuhn merged patch set 4 05/02/13, 18:18