Review main Merged

20439[BUGFIX] Remove 1000 pixelx limitation for preview image

Fabien Udriot CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

There is a limitation of 1000 pixels width / height when creating a
preview image, also known as ProcessedFile::CONTEXT_IMAGEPREVIEW

The limitation is artificial and subjective and should be removed letting
more freedom to the system, e.g for generating banner which are quite
large.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Alexander Opitz +1
    • Christian Kuhn +1
  • Verified V +2
    • Wouter Wolters +2
    • Alexander Opitz +1
    • Christian Kuhn +1

Issues 1

Files 1

Review log 22

  1. Markus Klein commented on patch set 2 05/08/13, 06:43

    Looks good to me, but someone else must approve
    Please use one line for these. (I'm not sure how the merged issues script reacts here)
  2. Markus Klein uploaded patch set 3 05/08/13, 06:43

  3. Markus Klein commented on patch set 3 05/08/13, 06:43

    Verified; Looks good to me, but someone else must approve
  4. Alexander Opitz commented on patch set 2 05/08/13, 06:43

    I would prefer that you didn't submit this

    LocalPreviewHelper.php:66

    Shouldn't this not better replaced with $configuration['width'] = (int) $configuration['width']; $configuration['height'] = (int) $configuration['height']; ? Else we would need escapeshellargs some lines down.
  5. Alexander Opitz commented on patch set 3 05/08/13, 06:43

    Verified; Looks good to me, but someone else must approve
  6. Alexander Opitz commented on patch set 3 05/08/13, 06:43

    (1 inline comment)
  7. Alexander Opitz commented on patch set 3 1 comment 05/08/13, 06:43

    No score
  8. Christian Kuhn commented on patch set 3 05/08/13, 06:43

    (1 inline comment)

    LocalPreviewHelper.php:66

    Does it make sense to at least force a positive integer?

    LocalPreviewHelper.php:66 Reply

    yeah, thats why i ask: width and height *must* be positive, and forceIntegerInRange takes care of that ( -100 -> +1, after that). So, it might make sense, to not only (int) cast it, but also force it to be creater than zero here?
  9. Christian Kuhn commented on patch set 3 05/08/13, 06:43

    (1 inline comment)
  10. Fabien Udriot uploaded patch set 2 05/08/13, 06:43

    LocalPreviewHelper.php:66 Reply

    Looks as the good solution for me solving all concerns, positive value + casting. +1 for a new patch
  11. Fabien Udriot commented on patch set 3 05/08/13, 06:43

    (1 inline comment)
  12. Alexander Opitz commented on patch set 4 05/08/13, 06:43

    Verified; Looks good to me, but someone else must approve
  13. Christian Kuhn commented on patch set 4 05/08/13, 06:43

    Verified; Looks good to me, but someone else must approve
  14. Fabien Udriot uploaded patch set 4 05/08/13, 06:43

  15. Fabien Udriot commented on patch set 4 05/08/13, 06:43

    In last patch, went with approach Utility\MathUtility::forceIntegerInRange($configuration['height'], 1) for solving positive value + casting of width and height.
  16. Mr. Jenkins commented on patch set 1 05/08/13, 06:43

  17. Mr. Jenkins commented on patch set 2 05/08/13, 06:43

  18. Mr. Jenkins commented on patch set 3 05/08/13, 06:43

  19. Mr. Jenkins commented on patch set 4 05/08/13, 06:43

  20. Wouter Wolters commented on patch set 2 05/08/13, 06:43

    Looks good to me, but someone else must approve
  21. Wouter Wolters commented on patch set 4 V 0 05/08/13, 06:43

    by team member; Looks good to me, approved
  22. Wouter Wolters merged patch set 5 05/08/13, 06:43