Review main Merged

20463[TASK] Minor Installer.php clean up

Christian Kuhn CR +2 V +2 Hard +447 −428 updated 06/03/13, 20:49

Commit message

Split method setupGeneral() to two methods.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Thomas Maroschik +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
  • Verified V +2
    • Christian Kuhn +2
    • Thomas Maroschik +1
    • Anja Leichsenring +1

Issues 1

Files 1

Review log 6

  1. Thomas Maroschik commented on patch set 1 05/05/13, 10:36

    Verified; Looks good to me, but someone else must approve
  2. Anja Leichsenring commented on patch set 1 05/05/13, 10:36

    Verified; Looks good to me, but someone else must approve
  3. Mr. Jenkins commented on patch set 1 05/05/13, 10:36

  4. Wouter Wolters commented on patch set 1 05/05/13, 10:36

    Looks good to me, but someone else must approve
  5. Christian Kuhn commented on patch set 1 V 0 05/05/13, 10:36

    by team member; Looks good to me, approved
  6. Christian Kuhn merged patch set 2 05/05/13, 10:36