Review main Merged

20467[BUGFIX] displayCond in flexforms broken

Stefan Galinski CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Benni Mack +2
    • Wouter Wolters +1
  • Verified V +2
    • Benni Mack +2
    • Wouter Wolters +1

Files 1

Review log 4

  1. Benni Mack commented on patch set 1 V 0 05/04/13, 08:34

    by team member; Looks good to me, approved
  2. Mr. Jenkins commented on patch set 1 05/04/13, 08:34

  3. Wouter Wolters commented on patch set 1 05/04/13, 08:34

    Verified; Looks good to me, but someone else must approve The check in ElementConditionMatcher is strict: if ($this->flexformValueKey === 'vDEF') {
  4. Benni Mack merged patch set 2 05/04/13, 08:34