Review main Merged

20487[BUGFIX] Resolve asterisk in allowed tables for suggest wizard

Nicole Hummel CR +2 V +2 Easy +16 −1 updated 06/03/13, 20:49

Commit message

In the suggest ajax script the setting of allowed tables is not parsed for
the asterisk (*). If it is set all TCA tables should be parsed and checked
for access and added to queryTables array.

Review

  • Code review CR +2
    • Nicole Hummel +2
  • Verified V +2
    • Nicole Hummel +2

Files 1

Review log 13

  1. Mr. Jenkins commented on patch set 1 05/05/13, 11:41

  2. Georg Ringer commented on patch set 3 05/05/13, 11:41

    Verified; Looks good to me, but someone else must approve
  3. Philipp Gampe uploaded patch set 3 05/05/13, 11:41

  4. Philipp Gampe commented on patch set 3 05/05/13, 11:41

    Verified; Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 2 05/05/13, 11:41

  6. Mr. Jenkins commented on patch set 3 05/05/13, 11:41

  7. Nicole Hummel commented on patch set 2 05/05/13, 11:41

    Add 6.2 in commit message
  8. Nicole Hummel uploaded patch set 2 05/05/13, 11:41

  9. Nicole Hummel commented on patch set 3 V 0 05/05/13, 11:41

    by team member; Looks good to me, approved
  10. Nicole Hummel commented on patch set 3 05/05/13, 11:41

    Verified; Looks good to me, but someone else must approve
  11. Nicole Hummel commented on patch set 4 V 0 05/05/13, 11:41

    by team member; Looks good to me, approved Only rebase
  12. Nicole Hummel uploaded patch set 4 05/05/13, 11:41

  13. Nicole Hummel merged patch set 5 05/05/13, 11:41